[wxchartdir] Add new port #7914
Merged
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arm, uwp and static are not supported because of chartdir |
ras0219-msft
requested changes
Sep 3, 2019
| project(wxchartdir CXX) | ||
|
|
||
| set(wxWidgets_EXCLUDE_COMMON_LIBRARIES TRUE) | ||
| find_package(wxWidgets REQUIRED COMPONENTS core base) |
There was a problem hiding this comment.
Instead of pulling an entirely separate git repo, we should either
a) Add CMake find_package support into the wxwidgets package (and use that)
b) Inline the find_library()/find_include() lines here. Since this only needs to handle vcpkg, this should be no more than 20 lines or so
There was a problem hiding this comment.
Totally agree. It would be the best/ideal solution.
I just want to share my solution with vcpkg community and I don't see big problem with pulling additional repo, which helps to build the library.
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/utelle/wxchartdir