-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[liblsl] Update library to 1.13.0-b11 #7906
Conversation
@cbezault @ehsan-mohammadi lslver is an executable. Why has it been arbitrarily transformed into a static library and why the change has been approved with a patch? |
@cenit Thanks for reviewing this PR! When we try to install |
liblsl.exe should have been moved to the tools folder or removed, not transformed into a "fake" library. |
@cenit I know, and thanks a lot for helping me. I'm new in |
no problem, it's not against you of course. On your side, since it seems that the green mark is usually enough to grant a merge, please try to do your best to improve port and not just modify references to a newer release: check every patch (new and already existing) to be sure that works and is valid, check tools if properly installed with a feature, verify if any feature is missing or non-working (CI, for ports without dependencies that might trigger extra ones, just checks default features, unfortunately), try to use the library in a dependent project. Just trying to link to it with cmake would be enough and very easy to do, even without any project. It wouldn't make you sure that the library fulfills consumers' expectations, but at least you are verifying that the toolchain in properly in place |
@cenit Thanks a lot. I will warmly welcome your comments. |
liblsl
library to 1.13.0-b11 version.fix-install.patch
patch file to remove.exe
files and avoid build failing.