Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[duktape] Update library to 2.4.0 #7873

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Conversation

ehsan-mohammadi
Copy link
Contributor

Update duktape library to 2.4.0 version.

@ehsan-mohammadi ehsan-mohammadi marked this pull request as ready for review August 24, 2019 15:14
@ehsan-mohammadi ehsan-mohammadi deleted the dev6 branch August 25, 2019 07:16
@ehsan-mohammadi ehsan-mohammadi restored the dev6 branch August 25, 2019 07:22
@ehsan-mohammadi
Copy link
Contributor Author

Refer to #7548 (comment):

"duktape build failed on Linux because it requires tools from the system package manager: python-yaml. This tool needs to install manually. There are comments in duktape's portfile.cmake."

@Rastaban
Copy link
Contributor

python-yaml is one of the packages we install on all of our Linux VMs so it should be there. I will look into it.

@Rastaban
Copy link
Contributor

Looks like the pip hash needs to be updated.

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:96 (message):

  File does not have expected hash:

          File path: [ /home/vcpkg/myagent/_work/1/s/downloads/tools/python/python2/get-pip.py ]
      Expected hash: [ 1436215d2bc45a8019503aaf6c0e5f7da142108dee0fa2db282e22670eca84beff487ec45f1e6b8968c481f7009afb211a76ac93b637b48ba83f099831db33ff ]
        Actual hash: [ 99520d223819708b8f6e4b839d1fa215e4e8adc7fcd0db6c25a0399cf2fa10034b35673cf450609303646d12497f301ef53b7e7cc65c78e7bce4af0c673555ad ]

  Please delete the file and retry if this file should be downloaded again.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:107 (test_hash)
  ports/duktape/portfile.cmake:30 (vcpkg_download_distfile)
  scripts/ports.cmake:85 (include)

@ehsan-mohammadi
Copy link
Contributor Author

@Rastaban Many thanks for reviewing. I updated the pip hash.

@Rastaban Rastaban merged commit 2d60eea into microsoft:master Aug 28, 2019
@ehsan-mohammadi ehsan-mohammadi deleted the dev6 branch August 28, 2019 20:11
@cenit
Copy link
Contributor

cenit commented Aug 29, 2019

Looks like the pip hash needs to be updated.

does it means that the move to use a fixed release (3.3 in the address) is still not working as expected? :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants