Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg]Port toolchains #7687

Merged
merged 10 commits into from
Aug 20, 2019
Merged

[vcpkg]Port toolchains #7687

merged 10 commits into from
Aug 20, 2019

Conversation

cbezault
Copy link
Contributor

This PR allows ports to install a cmake file which will be automatically included by all dependents.

@cbezault cbezault added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 14, 2019
@cbezault cbezault self-assigned this Aug 14, 2019
@cbezault cbezault added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 14, 2019
@cbezault cbezault requested a review from ras0219-msft August 14, 2019 20:40
@cbezault cbezault requested review from strega-nil and vicroms August 16, 2019 20:54
strega-nil
strega-nil approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Just some minor changes are needed :)

toolsrc/include/vcpkg/base/util.h Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/build.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/build.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/dependencies.cpp Outdated Show resolved Hide resolved
@cbezault
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

@cbezault you have to change toolsrc/include/vcpkg/base/util.h:140 before it'll compile

@cbezault
Copy link
Contributor Author

Yeah realized after that last one, just reran because that's a reflex at this point.

@cbezault cbezault merged commit 4da95d6 into microsoft:master Aug 20, 2019
@cenit
Copy link
Contributor

cenit commented Aug 21, 2019

Since this PR has been merged, many ports are exhibiting warnings like this:

Building package boost-histogram[core]:x64-windows...
Warning: abi keys are missing values:
    boost-assert
    boost-callable-traits
    boost-config
    boost-core
    boost-integer
    boost-iterator
    boost-mp11
    boost-serialization
    boost-throw-exception
    boost-variant
    boost-vcpkg-helpers

is it ok?

@cbezault
Copy link
Contributor Author

Yes it's OK, I should have made the warning more clear with the PR. I'll be doing that soon.

@cbezault
Copy link
Contributor Author

If you want those errors to go away you're going to need to do a full rebuild of all your libraries. Otherwise it's safe to ignore.

@cenit
Copy link
Contributor

cenit commented Aug 21, 2019

ok thanks.

strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@cbezault
[vcpkg]Port toolchains (microsoft#7687)
9307404 
* checkpoint commit

* Only set VCPKG_ENV_OVERRIDES_FILE if it exists

* First pass at working port-toolchain

* Update VERSION.txt

* Return rvalue

* Fix compilation error

* Some fixes are requested by @ubsan

* Fix another compilation error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

@vicroms vicroms Awaiting requested review from vicroms

Assignees

@cbezault cbezault

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbezault @strega-nil @cenit