[libyuv] Add libyuv #7486
Merged
[libyuv] Add libyuv #7486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de7bcac to
22a2cae
Compare
Add libyuv
22a2cae to
8cf2521
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cbezault
suggested changes
Sep 10, 2019
| @@ -0,0 +1,4 @@ | |||
| Source: libyuv | |||
| Version: fec9121 | |||
| Build-Depends: libjpeg-turbo | |||
There was a problem hiding this comment.
You likely don't depend on the default features, please specify exactly what features you depend on.
There was a problem hiding this comment.
yuvconvert requires libjpeg (or libjpeg-turbo). And, yuv_shared needed it.
There was a problem hiding this comment.
What I was suggesting was that you write something like this: libjpeg-turbo[core, feature1, feature2, ...], it's fine for now but we're probably going to want to change it in the future.
|
@cbezault Please re-review! Thanks, |
cbezault
approved these changes
Sep 17, 2019
| @@ -0,0 +1,4 @@ | |||
| Source: libyuv | |||
| Version: fec9121 | |||
| Build-Depends: libjpeg-turbo | |||
There was a problem hiding this comment.
What I was suggesting was that you write something like this: libjpeg-turbo[core, feature1, feature2, ...], it's fine for now but we're probably going to want to change it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add libyuv.