Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port anyrpc #7438

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Add port anyrpc #7438

merged 4 commits into from
Sep 3, 2019

Conversation

faaxm
Copy link
Contributor

@faaxm faaxm commented Jul 26, 2019

This PR adds a port for AnyRPC (https://github.com/sgieseking/anyrpc). This library provides clients and servers for multiple remote procedure call protocols.

@msftclas
Copy link

msftclas commented Jul 26, 2019

CLA assistant check
All CLA requirements met.

Added missing `vcpkg_install_cmake()`
@dan-shaw
Copy link
Contributor

dan-shaw commented Aug 9, 2019

Thanks for the PR! On the arm CI builds, it has an error:

Unknown machine endianess detected. User needs to define ANYRPC_ENDIAN.

@faaxm
Copy link
Contributor Author

faaxm commented Aug 27, 2019

@dan-shaw Sorry for the late reply, I didn't find time to look into this earlier... Is there a way to retrigger the build and get some more information? It seems like the logs are no longer available...

@dan-shaw
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dan-shaw
Copy link
Contributor

dan-shaw commented Aug 27, 2019

@faaxm You should be able to see the logs now.

Edit: Let me know if you still can't.

faaxm added 2 commits August 28, 2019 14:30
Added patch to detect endianness on ARM.
further tweaks to endianness detection.
@faaxm
Copy link
Contributor Author

faaxm commented Aug 28, 2019

@dan-shaw Found a way to patch anyrpc to know the endianness for ARM when built via VS.
I am not supper happy with this as I had to assume that compiling for ARM with visual studio is always for a little-endian ARM-platform, but to my knowledge that should be valid...

Do you know more about this?

Will eventually submit this patch to the anyrpc-repo....

Also... If this gets merged eventually, will you squash the commits? Or should I do a force push where the commit history is a bit cleaned up?

@dan-shaw
Copy link
Contributor

dan-shaw commented Sep 3, 2019

@faaxm Sorry for the delay. I believe compiling for ARM is always in little-endian on Windows. Other than that, the PR looks good. I will squash the commits then merge it - thanks for the PR!

@dan-shaw dan-shaw merged commit 6171b91 into microsoft:master Sep 3, 2019
@faaxm faaxm deleted the add_anyrpc branch January 14, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants