Adding WREN to vcpkg #7242
Adding WREN to vcpkg #7242
Conversation
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
What binaries is this expected to create? Is there supposed to be a wren executable? All I see right now is a library binary and two headers. Will projects that depend on wren need to use wren to build anything or is the wren executable only needed by the end user?
Actually is |
ports/wren/CMakeLists.txt
Outdated
| @@ -24,29 +20,20 @@ file(GLOB vm_SRCS ${vm_DIR}/*.c) | |||
|
|
|||
| set(wren_SRCS ${vm_SRCS} ${opt_SRCS}) | |||
|
|
|||
| add_library(wren ${wren_SRCS}) | |||
| add_library(wren STATIC ${wren_SRCS}) | |||
There was a problem hiding this comment.
You should probably not explicitly set STATIC here. find_library respects BUILD_SHARED_LIBS if set and that should be preferred.
If Wren really needs to be built statically you can use a vcpkg_check_linkage call in the portfile to force BUILD_SHARED_LIBS to be set to off.
I know this might sound kind of silly but it's more consistent with how we would deal with a port where the CMakeLists.txt is provided for us.
This is a first pass port of wren to address #7221
I'm still fairly new to vcpkg and am not sure how to get debug/release static/dynamic builds