Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-make] Fix the missing value #43121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LilyWangLL
Copy link
Contributor

Fixes #43116

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 6, 2025
@Neumann-A
Copy link
Contributor

should probably add a test for it in vcpkg-make-tests

@Mayhem1380
Copy link

fix all issues and permission to import to my wallets

@LilyWangLL LilyWangLL marked this pull request as ready for review January 7, 2025 01:36
@LilyWangLL
Copy link
Contributor Author

should probably add a test for it in vcpkg-make-tests

Which function do you mean want to add test for? Is it z_vcpkg_set_global_property?

@Neumann-A
Copy link
Contributor

Test for the case which broke the function?

@LilyWangLL
Copy link
Contributor Author

Test for the case which broke the function?

This issue occurred because the user modified the environment variables, which triggered this function and detected the error. Ping the author of port @JavierMatosD, do we still need to add test cases for port vcpkg-make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg-make] bug: incorrect number of arguments to function
4 participants