Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-ci-mdl-sdk] Add test port. #43118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jreichel-nvidia
Copy link
Contributor

Add test port to prevent future regressions of mdl-sdk features, in particular for the openimageio feature, as it happened in #37489.

(I believe the unchecked items below do not really apply for new test ports.)

  • Changes comply with the [maintainer guide]
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Add test port to prevent future regressions of mdl-sdk features, in particular
for the openimageio feature, as it happened in microsoft#37489.
@jreichel-nvidia jreichel-nvidia marked this pull request as ready for review January 6, 2025 14:12
@Mengna-Li Mengna-Li added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Jan 7, 2025
"version-string": "ci",
"description": "Port to force features of certain ports within CI",
"license": "BSD-3-Clause",
"supports": "!x86 & !(windows & (staticcrt | arm | uwp | static)) & !(osx & arm) & !android",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"supports": "!x86 & !(windows & (staticcrt | arm | uwp | static)) & !(osx & arm) & !android",

Just let the test port run when mdl-sdk is supported. No need to maintain duplicate top-level restrictions.
(Restriction can be useful on a feature or dependency level, to not request unsupported dependencies.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants