[openmvg] Fix linux build #43117
Open
[openmvg] Fix linux build #43117
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
commented
Jan 6, 2025
| @@ -832,7 +832,6 @@ openmesh:x64-uwp=fail | |||
| openmpi:arm-neon-android=fail | |||
| openmpi:arm64-android=fail | |||
| openmpi:x64-android=fail | |||
| openmvg:x64-linux=fail | |||
There was a problem hiding this comment.
This record is added in #32014 (comment)
Either coin-or-clp or coin-or-osi or coinutils can be built on linux now.
There was a problem hiding this comment.
This record is added in #32014 (comment) Either coin-or-clp or coin-or-osi or coinutils can be built on linux now.
The coin stuff was unblocked at that time, so the openmvg problem was no longer hidden by a cascade. It might have been investigated at that time.
7 tasks
MonicaLiu0311
approved these changes
Jan 6, 2025
dg0yt
reviewed
Jan 7, 2025
| endif() | ||
|
|
||
| vcpkg_cmake_config_fixup() | ||
| vcpkg_cmake_config_fixup(PACKAGE_NAME openMVG CONFIG_PATH lib/openMVG/cmake) |
There was a problem hiding this comment.
Suggested change
| vcpkg_cmake_config_fixup(PACKAGE_NAME openMVG CONFIG_PATH lib/openMVG/cmake) | |
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/openMVG/cmake) |
PACKAGE_NAME only affects the chosen directory name. CMake is case-insensitive with regard to the directory name. We want the config to live in the lower-case directory openmvg which matches the port name. This is also the default PACKAGE_NAME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43106
./vcpkg x-add-version --alland committing the result.