-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google-cloud-cpp] update to the latest release (v2.23) #38204
[google-cloud-cpp] update to the latest release (v2.23) #38204
Conversation
8fab892
to
8d89bee
Compare
2976098
to
d4df16e
Compare
I am not sure what the build failure is. Does running the following make any changes? If so, try committing them.
|
d4df16e
to
b4f6728
Compare
Fixed it thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenSSL is no longer a dependency on Windows (googleapis/google-cloud-cpp#13785).
@alevenberg you need to run |
Thanks. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Port usage tests pass with following triplets:
- x64-windows
Updates google-cloud-cpp to the latest release (v2.23.0)
Removed
DGOOGLE_CLOUD_CPP_ENABLE_CTYPE_CORD_WORKAROUND
since it is no longer used because it is automatically set now (googleapis/google-cloud-cpp#13877).Tested locally (on x64-linux) with:
and
./vcpkg x-add-version --all
and committing the result.