Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libffi] Fix undefined function error #34404

Merged
merged 28 commits into from
Oct 13, 2023
Merged

Conversation

jimwang118
Copy link
Contributor

Fixes #34261

^ 2 warnings generated. ./../src/libffi-3-84fbdc7636.clean/src/tramp.c:262:22: error: call to undeclared function 'open_temp_exec_file'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 262 | tramp_globals.fd = open_temp_exec_file (); | ^ 1 error generated. make[2]: *** [Makefile:1320: src/tramp.lo] Error 1 make[2]: *** Waiting for unfinished jobs....

Add the patch corresponding to the function definition based on the upstream PR 764.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-linux

jimwang118 and others added 28 commits August 17, 2023 15:06
@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Oct 11, 2023
@jimwang118 jimwang118 added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 11, 2023
@jimwang118 jimwang118 marked this pull request as ready for review October 12, 2023 01:46
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Oct 12, 2023
@BillyONeal BillyONeal merged commit 8801234 into microsoft:master Oct 13, 2023
@BillyONeal
Copy link
Member

Thanks for submitting upstream!

@jimwang118 jimwang118 deleted the fixlibffi branch October 13, 2023 05:59
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libiffi] build failure
3 participants