Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adios2] Add zfp feature #29678

Merged
merged 2 commits into from
Feb 21, 2023
Merged

[adios2] Add zfp feature #29678

merged 2 commits into from
Feb 21, 2023

Conversation

moritz-h
Copy link
Contributor

Add zfp feature to the adios2 port.
The latest adios2 (stable) release wants zfp 0.5.1, but the vcpkg zfp port is already at 1.0, therefore, backport zfp 1.0 support as patch (see ornladios/ADIOS2#3312 and ornladios/ADIOS2#3303 (comment)).
There is a release candidate available for the next adios2 version supporting zfp 1.0 directly. But the next adios2 version also uses Blosc2 instead of Blosc, and the current Blosc port is still at 1.x (I don't know how big this update will be, but there are a few other ports requiring it). And I'm unsure if you generally want release candidates in ports in vcpkg.
Therefore, I think patching zfp 1.0 support seems to be the simplest option for now.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Feb 15, 2023
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 16, 2023
JonLiu1993
JonLiu1993 previously approved these changes Feb 16, 2023
@JonLiu1993
Copy link
Member

JonLiu1993 commented Feb 16, 2023

Feature zfp tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 16, 2023
@JavierMatosD JavierMatosD added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 16, 2023
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 20, 2023
@JavierMatosD JavierMatosD merged commit 3768a4d into microsoft:master Feb 21, 2023
@moritz-h moritz-h deleted the adios2-zfp branch February 21, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants