Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-iot-sdk-c] LTS release 2022-01-21 #22696

Merged
merged 8 commits into from
Jan 26, 2022
Merged

[azure-iot-sdk-c] LTS release 2022-01-21 #22696

merged 8 commits into from
Jan 26, 2022

Conversation

momuno
Copy link
Member

@momuno momuno commented Jan 22, 2022 •
edited
Loading

  • What does your PR fix?

LTS release for 2022-01-21

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Unchanged

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot requested changes Jan 22, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout df40d1c476dc02d71b113e4a63c3a32b00ebb5bd -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index 65623e3..44118ca 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0dad59cefb765a175777e166c66893124c3011b0",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "6898a05e54b88637fc5a42136facc194b84e71a1",
       "version-date": "2021-09-09",
diff --git a/versions/a-/azure-iot-sdk-c.json b/versions/a-/azure-iot-sdk-c.json
index 56fd640..bcd70f5 100644
--- a/versions/a-/azure-iot-sdk-c.json
+++ b/versions/a-/azure-iot-sdk-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "fc1fb060120ea843179f2da888905a7cc82f4234",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "3d6dc98460c69e8690f9b20f62cf75e9e3ef7f2d",
       "version-date": "2021-09-09",
diff --git a/versions/a-/azure-macro-utils-c.json b/versions/a-/azure-macro-utils-c.json
index 9b9d201..f0dd734 100644
--- a/versions/a-/azure-macro-utils-c.json
+++ b/versions/a-/azure-macro-utils-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "0c90715278e5ab77af983254bdf17571bf69c55b",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "a951ed2a9b24f8778b7c2fb2ff4e6a6577ac6472",
       "version-string": "2020-06-17",
diff --git a/versions/a-/azure-uamqp-c.json b/versions/a-/azure-uamqp-c.json
index d74b7af..ba8a9b1 100644
--- a/versions/a-/azure-uamqp-c.json
+++ b/versions/a-/azure-uamqp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a2c6897e3392683dcce93a846b98b2c95dc41a55",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "4748ea8df9903436ad4b2b6462ca3ffdf74465d4",
       "version-date": "2021-09-09",
diff --git a/versions/a-/azure-uhttp-c.json b/versions/a-/azure-uhttp-c.json
index 66a7e23..fccde34 100644
--- a/versions/a-/azure-uhttp-c.json
+++ b/versions/a-/azure-uhttp-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "d56e12826c0c5d558cbcb75c3bcb68287df19b63",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "8dfc1d65397c35c27df08f42b2f77caf27661a9b",
       "version-date": "2021-09-09",
diff --git a/versions/a-/azure-umqtt-c.json b/versions/a-/azure-umqtt-c.json
index c877c9e..d7166f8 100644
--- a/versions/a-/azure-umqtt-c.json
+++ b/versions/a-/azure-umqtt-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "26c7310a2fd459b26b24c4d4daed805f710bafb5",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "2a208bf94bfaf91cc20716d7ba0caac0023324b0",
       "version-date": "2021-09-09",
diff --git a/versions/baseline.json b/versions/baseline.json
index b8df750..54d6aa1 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -313,7 +313,7 @@
       "port-version": 1
     },
     "azure-c-shared-utility": {
-      "baseline": "2021-09-09",
+      "baseline": "2022-01-21",
       "port-version": 0
     },
     "azure-core-cpp": {
@@ -325,7 +325,7 @@
       "port-version": 0
     },
     "azure-iot-sdk-c": {
-      "baseline": "2021-09-09",
+      "baseline": "2022-01-21",
       "port-version": 0
     },
     "azure-kinect-sensor-sdk": {
@@ -333,8 +333,8 @@
       "port-version": 4
     },
     "azure-macro-utils-c": {
-      "baseline": "2020-06-17",
-      "port-version": 3
+      "baseline": "2022-01-21",
+      "port-version": 0
     },
     "azure-security-keyvault-certificates-cpp": {
       "baseline": "4.0.0-beta.1",
@@ -373,15 +373,15 @@
       "port-version": 0
     },
     "azure-uamqp-c": {
-      "baseline": "2021-09-09",
+      "baseline": "2022-01-21",
       "port-version": 0
     },
     "azure-uhttp-c": {
-      "baseline": "2021-09-09",
+      "baseline": "2022-01-21",
       "port-version": 0
     },
     "azure-umqtt-c": {
-      "baseline": "2021-09-09",
+      "baseline": "2022-01-21",
       "port-version": 0
     },
     "b64": {
@@ -7029,8 +7029,8 @@
       "port-version": 2
     },
     "umock-c": {
-      "baseline": "2020-06-17",
-      "port-version": 2
+      "baseline": "2022-01-21",
+      "port-version": 0
     },
     "unicorn": {
       "baseline": "2020-09-14",
diff --git a/versions/u-/umock-c.json b/versions/u-/umock-c.json
index ec6028e..3668261 100644
--- a/versions/u-/umock-c.json
+++ b/versions/u-/umock-c.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "67f2fda1636719281706ebef0314a388ba5c8d15",
+      "version-date": "2022-01-21",
+      "port-version": 0
+    },
     {
       "git-tree": "b34153650a29eb81f88e48f53bd06ca05d4383c4",
       "version-string": "2020-06-17",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

github-actions[bot]
github-actions bot requested changes Jan 22, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout df40d1c476dc02d71b113e4a63c3a32b00ebb5bd -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/a-/azure-uhttp-c.json b/versions/a-/azure-uhttp-c.json
index 6ae9be8..fccde34 100644
--- a/versions/a-/azure-uhttp-c.json
+++ b/versions/a-/azure-uhttp-c.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "a2c6897e3392683dcce93a846b98b2c95dc41a55",
+      "git-tree": "d56e12826c0c5d558cbcb75c3bcb68287df19b63",
       "version-date": "2022-01-21",
       "port-version": 0
     },
diff --git a/versions/baseline.json b/versions/baseline.json
index 8dbfb09..54d6aa1 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -313,7 +313,7 @@
       "port-version": 1
     },
     "azure-c-shared-utility": {
-      "baseline": "2021-01-21",
+      "baseline": "2022-01-21",
       "port-version": 0
     },
     "azure-core-cpp": {

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

github-actions[bot]
github-actions bot approved these changes Jan 22, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@momuno momuno marked this pull request as ready for review January 22, 2022 01:44
@momuno momuno marked this pull request as draft January 22, 2022 01:46
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 24, 2022
@JonLiu1993 JonLiu1993 self-assigned this Jan 24, 2022
github-actions[bot]
github-actions bot requested changes Jan 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout df40d1c476dc02d71b113e4a63c3a32b00ebb5bd -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index 44118ca..08c65ae 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "0dad59cefb765a175777e166c66893124c3011b0",
+      "git-tree": "eb9ea23fc6e3fa016f710e2962bf549faa692b3f",
       "version-date": "2022-01-21",
       "port-version": 0
     },
diff --git a/versions/a-/azure-iot-sdk-c.json b/versions/a-/azure-iot-sdk-c.json
index bcd70f5..e3876c5 100644
--- a/versions/a-/azure-iot-sdk-c.json
+++ b/versions/a-/azure-iot-sdk-c.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "fc1fb060120ea843179f2da888905a7cc82f4234",
+      "git-tree": "77b1d419b740dd9738f237a6d52b1c161e99ee9d",
       "version-date": "2022-01-21",
       "port-version": 0
     },
diff --git a/versions/a-/azure-uhttp-c.json b/versions/a-/azure-uhttp-c.json
index fccde34..ec05c1d 100644
--- a/versions/a-/azure-uhttp-c.json
+++ b/versions/a-/azure-uhttp-c.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "d56e12826c0c5d558cbcb75c3bcb68287df19b63",
+      "git-tree": "f614a1ac990dd4189b292fa0e6e31897ee4b7ae8",
       "version-date": "2022-01-21",
       "port-version": 0
     },
diff --git a/versions/a-/azure-umqtt-c.json b/versions/a-/azure-umqtt-c.json
index d7166f8..c523e9e 100644
--- a/versions/a-/azure-umqtt-c.json
+++ b/versions/a-/azure-umqtt-c.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "26c7310a2fd459b26b24c4d4daed805f710bafb5",
+      "git-tree": "f5b18f17519b9de8a2ab956eebc7dff6e7bf7a05",
       "version-date": "2022-01-21",
       "port-version": 0
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@momuno momuno marked this pull request as ready for review January 24, 2022 23:51
github-actions[bot]
github-actions bot approved these changes Jan 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@momuno
Copy link
Member Author

momuno commented Jan 25, 2022

Hi @JonLiu1993 . Ready for merge. Thanks!

@dg0yt
Copy link
Contributor

dg0yt commented Jan 25, 2022

Does this update resolve #22777?

I don't know the canonical form of using this port in a cmake user project, but I feel like the auto-generated usage after vcpkg install azure-iot-sdk-c should be replaced by an explicit usage file.

@momuno
Copy link
Member Author

momuno commented Jan 26, 2022

Does this update resolve #22777?

I don't know the canonical form of using this port in a cmake user project, but I feel like the auto-generated usage after vcpkg install azure-iot-sdk-c should be replaced by an explicit usage file.

Investigating. Thanks for the heads up.

github-actions[bot]
github-actions bot requested changes Jan 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index 08c65ae..cf9f3e4 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -1,10 +1,15 @@
 {
   "versions": [
     {
-      "git-tree": "eb9ea23fc6e3fa016f710e2962bf549faa692b3f",
+      "git-tree": "1d0590ad121eefc3af9ff13f67996ca8c3e39508",
       "version-date": "2022-01-21",
       "port-version": 0
     },
+    {
+      "git-tree": "f2f3f9c6b03d02268920eee133f660bf2fe5d946",
+      "version-date": "2021-09-09",
+      "port-version": 1
+    },
     {
       "git-tree": "6898a05e54b88637fc5a42136facc194b84e71a1",
       "version-date": "2021-09-09",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

github-actions[bot]
github-actions bot requested changes Jan 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated 
git add -u && git commit
git checkout b41cc261730535f05cc1d0efbcaa821f2162f49e -- versions
./vcpkg x-add-version --all
Diff 
diff --git a/versions/a-/azure-c-shared-utility.json b/versions/a-/azure-c-shared-utility.json
index 1b273b7..cf9f3e4 100644
--- a/versions/a-/azure-c-shared-utility.json
+++ b/versions/a-/azure-c-shared-utility.json
@@ -5,6 +5,11 @@
       "version-date": "2022-01-21",
       "port-version": 0
     },
+    {
+      "git-tree": "f2f3f9c6b03d02268920eee133f660bf2fe5d946",
+      "version-date": "2021-09-09",
+      "port-version": 1
+    },
     {
       "git-tree": "6898a05e54b88637fc5a42136facc194b84e71a1",
       "version-date": "2021-09-09",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 26, 2022
github-actions[bot]
github-actions bot approved these changes Jan 26, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/azure-c-shared-utility/portfile.cmake
  • ports/azure-iot-sdk-c/portfile.cmake
  • ports/azure-uamqp-c/portfile.cmake
  • ports/azure-uhttp-c/portfile.cmake
  • ports/azure-umqtt-c/portfile.cmake
  • ports/umock-c/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/azure-c-shared-utility/vcpkg.json
  • ports/azure-iot-sdk-c/vcpkg.json
  • ports/azure-macro-utils-c/vcpkg.json
  • ports/azure-uamqp-c/vcpkg.json
  • ports/azure-uhttp-c/vcpkg.json
  • ports/azure-umqtt-c/vcpkg.json
  • ports/umock-c/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

ras0219-msft
ras0219-msft reviewed Jan 26, 2022
View reviewed changes
ports/azure-iot-sdk-c/improve-external-deps.patch
if(NOT ${use_installed_dependencies})
add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/parson)
else()
- find_package(parson REQUIRED CONFIG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If parson is now deploying config files, we should update parson so we can avoid this patch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ras0219-msft. I have created a task for my team for us to follow up on these patches. Thanks.

@ras0219-msft ras0219-msft merged commit c76e5f0 into microsoft:master Jan 26, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft left review comments

@dg0yt dg0yt dg0yt left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@momuno @dg0yt @ras0219-msft @JonLiu1993