-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fcl] Explicity handle FCL_USE_X64_SSE CMake option #11406
Conversation
The FCL_USE_X64_SSE option is enabled by default in fcl, but it only make sense to enable SSE flags when targeting either x86 or x64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traversaro, thanks for the PR!
Could you also update the Version to '0.6.0-1' in CONTROL file?
Done in traversaro@a02bab8 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the udpates!
The CI failed on 'git checkout' step, it doesn't related to this change, @strega-nil, could you help have a look? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Cools, LGTM! Thanks @traversaro :) I'll wait for the CI to finish and then merge. |
The CI failures doesn't relate to this changes. Failures: |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Alright, it passed! Thanks @traversaro :) |
The FCL_USE_X64_SSE option is enabled by default in fcl, but it only make sense to enable SSE flags when targeting either x86 or x64.
Related upstream PR: flexible-collision-library/fcl#470 .
What does your PR fix? There is no relative issue.
Which triplets are supported/not supported? Have you updated the CI baseline? The CI baseline should not change.
Does your PR follow the maintainer guide? Yes