Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http-client-csharp): wrong text/plain result conversion determination logic #5550

Conversation

archerzz
Copy link
Member

@archerzz archerzz commented Jan 9, 2025

We're using Operation.RequestMediaType to help determine the result conversion statement, which is apparently wrong.

This commit includes:

  • use Operation.Responses.ContentTypes to determine the result conversion statment for string return type
  • enable a previously disabled cadl ranch test Payload/MediaType/getAsText

part of #4208

…nation logic

We're using `Operation.RequestMediaType` to help determine the result conversion statement, which is apparently wrong.

This commit includes:
- use `Operation.Responses.ContentTypes` to determine the result conversion statment for `string` return type
- enable a previously disabled cadl ranch test `Payload/MediaType/getAsText`

part of microsoft#4208
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 9, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@JoshLove-msft JoshLove-msft added this pull request to the merge queue Jan 9, 2025
Merged via the queue into microsoft:main with commit 3b8c25a Jan 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants