SSL4EO-L: add additional metadata #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mypy error is a bit pedantic here. I don't really want to ignore it, but I also don't know an easy way to allow it. |
|
would |
2a8c3e8 to
841a4cd
Compare
nilsleh
reviewed
Feb 24, 2025
| @@ -148,6 +152,13 @@ class Landsat1(Landsat): | |||
| default_bands = ('B4', 'B5', 'B6', 'B7') | |||
| rgb_bands = ('B6', 'B5', 'B4') | |||
|
|
|||
| wavelengths: ClassVar[dict[str, float]] = { | |||
There was a problem hiding this comment.
In the S12 PR, you also added the alternative names, would that make sense here as well?
There was a problem hiding this comment.
As far as I know there are no datasets that use the alternative names, so no need yet.
841a4cd to
f39e99c
Compare
nilsleh
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.