Add BigEarthNet Version2 #2531
Merged
Add BigEarthNet Version2 #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsleh
commented
Jan 27, 2025
nilsleh
commented
Jan 27, 2025
|
@ando-shah in case you wanna have a look, since you have experience with the dataset already and find anything. |
adamjstewart
requested changes
Feb 9, 2025
There was a problem hiding this comment.
Once this is done I would love to squash this on top of #2371 so that @ando-shah gets some credit.
nilsleh
commented
Feb 14, 2025
adamjstewart
previously approved these changes
Feb 19, 2025
| self, | ||
| root: Path = 'data', | ||
| split: str = 'train', | ||
| bands: str = 'all', |
There was a problem hiding this comment.
People have complained that some datasets have (B1, B2, etc.) and others have s1, s2, etc. I know you're just matching the existing dataset, but should we change both to the former?
adamjstewart
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #2371 after talking to Ando.
After taking a look, the new version comes with a
metadata.parquetfile, which makes data handling quiet a bit more straightforward. With aversion=2argument, I felt like there would be many nested if statements and therefore, cleaner to do it this way. If there was a similarmetadata.parquetfile for V1, then this could be made more condensed.