Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Warning CS9113 : Parameter 'testFramework' is unread. #4846

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix Warning CS9113 : Parameter 'testFramework' is unread. #4846

merged 1 commit into from
Jan 31, 2025

Conversation

SimonCropp
Copy link
Contributor

No description provided.

Youssef1313
Youssef1313 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the warning locally, not sure why. But the change looks good to me.

@Evangelink Evangelink enabled auto-merge (squash) January 31, 2025 06:42
@Evangelink Evangelink merged commit bd96478 into microsoft:main Jan 31, 2025
9 checks passed
@SimonCropp
Copy link
Contributor Author

@Youssef1313

I don't see the warning locally, not sure why. But the change looks good to me.

i dont either in the ide, but they do show up in the text output of the build. i didnt bother digging in further into the disparity

@SimonCropp SimonCropp deleted the fix-Warning-CS9113-Parameter-'testFramework'-is-unread- branch January 31, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@Evangelink Evangelink Evangelink approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @Evangelink @Youssef1313