Add code fix for MSTEST0019

src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx

@@ -156,4 +156,7 @@
   <data name="ReplaceWithConstructorFix" xml:space="preserve">
     <value>Replace TestInitialize method with constructor</value>
   </data>
+  <data name="ReplaceWithTestInitializeFix" xml:space="preserve">
+    <value>Replace constructor with TestInitialize method</value>
+  </data>
 </root>

src/Analyzers/MSTest.Analyzers.CodeFixes/PreferTestInitializeOverConstructorFixer.cs

@@ -0,0 +1,115 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System.Collections.Immutable;
+using System.Composition;
+
+using Analyzer.Utilities;
+
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CodeActions;
+using Microsoft.CodeAnalysis.CodeFixes;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.Editing;
+using Microsoft.CodeAnalysis.Text;
+
+using MSTest.Analyzers.Helpers;
+
+namespace MSTest.Analyzers;
+
+[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(ClassInitializeShouldBeValidFixer))]
+[Shared]
+public sealed class PreferTestInitializeOverConstructorFixer : CodeFixProvider
+{
+    public override ImmutableArray<string> FixableDiagnosticIds { get; }
+        = ImmutableArray.Create(DiagnosticIds.PreferTestInitializeOverConstructorRuleId);
+
+    public override FixAllProvider GetFixAllProvider()
+        // See https://github.com/dotnet/roslyn/blob/main/docs/analyzers/FixAllProvider.md for more information on Fix All Providers
+        => WellKnownFixAllProviders.BatchFixer;
+
+    public override async Task RegisterCodeFixesAsync(CodeFixContext context)
+    {
+        SyntaxNode root = await context.Document.GetRequiredSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false);
+
+        Diagnostic diagnostic = context.Diagnostics[0];
+        TextSpan diagnosticSpan = diagnostic.Location.SourceSpan;
+
+        SyntaxToken syntaxToken = root.FindToken(diagnosticSpan.Start);
+        if (syntaxToken.Parent is null)
+        {
+            return;
+        }
+
+        // Find the constructor declaration identified by the diagnostic.
+        ConstructorDeclarationSyntax constructorDeclaration = syntaxToken.Parent.AncestorsAndSelf().OfType<ConstructorDeclarationSyntax>().FirstOrDefault();
+        if (constructorDeclaration == null)
+        {
+            return;
+        }
+
+        context.RegisterCodeFix(
+            CodeAction.Create(
+                CodeFixResources.ReplaceWithTestInitializeFix,
+                c => ReplaceConstructorWithTestInitializeAsync(context.Document, constructorDeclaration, c),
+                nameof(PreferTestInitializeOverConstructorFixer)),
+            diagnostic);
+    }
+
+    private static async Task<Document> ReplaceConstructorWithTestInitializeAsync(Document document, ConstructorDeclarationSyntax constructorDeclaration, CancellationToken cancellationToken)
+    {
+        DocumentEditor editor = await DocumentEditor.CreateAsync(document, cancellationToken).ConfigureAwait(false);
+
+        // Find the class containing the constructor
+        if (constructorDeclaration.Parent is ClassDeclarationSyntax containingClass)
+        {
+            // Check if a TestInitialize method already exists
+            MethodDeclarationSyntax? existingTestInitialize = containingClass.Members
+                .OfType<MethodDeclarationSyntax>()
+                .FirstOrDefault(m => m.AttributeLists
+                    .SelectMany(attrList => attrList.Attributes)
+                    .Any(attr => attr.Name.ToString().Contains("TestInitialize")));
+
+            // Move the body of the constructor
+            BlockSyntax? constructorBody = constructorDeclaration.Body;
+
+            if (existingTestInitialize != null)
+            {
+                // If TestInitialize exists, append the constructor body to it
+                StatementSyntax[]? constructorStatements = constructorBody?.Statements.ToArray();
+                MethodDeclarationSyntax newTestInitialize;
+                if (existingTestInitialize.Body != null)
+                {
+                    BlockSyntax newTestInitializeBody = existingTestInitialize.Body.AddStatements(constructorStatements ?? Array.Empty<StatementSyntax>());
+                    newTestInitialize = existingTestInitialize.WithBody(newTestInitializeBody);
+                }
+                else
+                {
+                    newTestInitialize = existingTestInitialize.WithBody(constructorBody);
+                }
+
+                editor.ReplaceNode(existingTestInitialize, newTestInitialize);
+            }
+            else
+            {
+                // Create a new TestInitialize method with the constructor body
+                MethodDeclarationSyntax testInitializeMethod = SyntaxFactory.MethodDeclaration(SyntaxFactory.PredefinedType(SyntaxFactory.Token(SyntaxKind.VoidKeyword)), "TestInitialize")
+                    .WithAttributeLists(
+                        SyntaxFactory.SingletonList(
+                            SyntaxFactory.AttributeList(
+                                SyntaxFactory.SingletonSeparatedList(
+                                    SyntaxFactory.Attribute(SyntaxFactory.IdentifierName("TestInitialize"))))))
+                    .WithModifiers(SyntaxFactory.TokenList(SyntaxFactory.Token(SyntaxKind.PublicKeyword)))
+                    .WithBody(constructorBody);
+
+                editor.AddMember(containingClass, testInitializeMethod);
+            }
+
+            // Remove the constructor
+            editor.RemoveNode(constructorDeclaration);
+        }
+
+        return editor.GetChangedDocument();
+    }
+}

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.cs.xlf

@@ -47,6 +47,11 @@
         <target state="translated">Nahradit metodu Dispose metodou TestCleanup</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Oprava podpisu testovací třídy</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.de.xlf

@@ -47,6 +47,11 @@
         <target state="translated">„Dispose“ durch eine TestCleanup-Methode ersetzen</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Testklassensignatur korrigieren</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.es.xlf

@@ -47,6 +47,11 @@
         <target state="translated">Reemplazar 'Dispose' por un método TestCleanup</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Corregir firma de clase de prueba</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.fr.xlf

@@ -47,6 +47,11 @@
         <target state="new">Replace 'Dispose' with a TestCleanup method</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Correction de la signature de classe de test</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.it.xlf

@@ -47,6 +47,11 @@
         <target state="translated">Sostituire "Dispose" con un metodo TestCleanup</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Correggi la firma della classe di test</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ja.xlf

@@ -47,6 +47,11 @@
         <target state="translated">'Dispose' を TestCleanup メソッドに置き換える</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">テスト クラスのシグネチャの修正</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ko.xlf

@@ -47,6 +47,11 @@
         <target state="translated">'Dispose'를 TestCleanup 메서드로 바꾸기</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">테스트 클래스 서명 수정</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pl.xlf

@@ -47,6 +47,11 @@
         <target state="translated">Zastąp metodę „Dispose” metodą TestCleanup</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Napraw podpis klasy testowej</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pt-BR.xlf

@@ -47,6 +47,11 @@
         <target state="translated">Substituir "Dispose" por um método TestCleanup</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Correção da assinatura de classe do teste</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ru.xlf

@@ -47,6 +47,11 @@
         <target state="translated">Заменить "Dispose" методом TestCleanup</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Исправить подпись класса теста</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.tr.xlf

@@ -47,6 +47,11 @@
         <target state="translated">'Dispose' öğesini bir TestCleanup yöntemiyle değiştir</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">Test sınıfı imzasını düzeltme</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hans.xlf

@@ -47,6 +47,11 @@
         <target state="translated">将“Dispose”替换为 TestCleanup 方法</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">修复测试类签名</target>

src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hant.xlf

@@ -47,6 +47,11 @@
         <target state="translated">以 TestCleanup 方法取代 'Dispose'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ReplaceWithTestInitializeFix">
+        <source>Replace constructor with TestInitialize method</source>
+        <target state="new">Replace constructor with TestInitialize method</target>
+        <note />
+      </trans-unit>
       <trans-unit id="TestClassShouldBeValidFix">
         <source>Fix test class signature</source>
         <target state="translated">修正測試類別簽章</target>