Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a control unittesting project #9677

Merged
3 commits merged into from
Apr 5, 2021
Merged

Create a control unittesting project #9677

3 commits merged into from
Apr 5, 2021

Conversation

zadjii-msft
Copy link
Member

Does what it says on the can.

This is a follow up to #9472. Now that we have a control .lib, we can add tests for it.

Unfortunately, the TermControl itself is a horrible mess. So this new unittest lib is empty for now. I'm working on actual tests as a part of #6842, but this PR is here to keep the diffs smaller.

Also, apparently server.vcxproj had the wrong GUID in it.

  • I work here
  • Adds tests

@github-actions

This comment has been minimized.

Sign in to view
miniksa
miniksa requested changes Mar 31, 2021
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why'd that one guid change? leftover mistake that VS fixed for us?

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 31, 2021
carlos-zamora
carlos-zamora approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael's handling the guid change. So I'mma just approve this since I don't see anything else worth blocking over.

@zadjii-msft zadjii-msft requested a review from miniksa April 2, 2021 10:36
@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Apr 2, 2021
@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 5, 2021
@ghost
Copy link

ghost commented Apr 5, 2021

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 24b9a7a into main Apr 5, 2021
@ghost ghost deleted the dev/migrie/control-unittests branch April 5, 2021 16:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zadjii-msft @carlos-zamora @miniksa