Fix command palette accessibility #9143
Conversation
|
@Don-Vito mind taking a look here? Want to make sure I'm not breaking any of the work you've done with the command palette. |
|
I think we removed the tabstops when making the palette ephemeral. Since then we made the mechanism more robust (using visual tree traversing to detect focus loss), so this change should be ok. Yet I will try to play with a palette later on, to see it doesn't close itself or something 😄 |
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes a regression of command palette accessibility. The regression was introduced in #8377 by setting `IsTabStop` to false. Though the commands would light up, the focus didn't technically get on the command, so the screen reader would just read the text box. Opened the command palette while NVDA is active. It now reads the commands as focus moves on them. (cherry picked from commit ac3e4bf)
|
🎉 Handy links: |
|
🎉 Handy links: |
Fixes a regression of command palette accessibility. The regression was
introduced in #8377 by setting
IsTabStopto false. Though the commandswould light up, the focus didn't technically get on the command, so the
screen reader would just read the text box.
Validation Steps Performed
Opened the command palette while NVDA is active. It now reads the
commands as focus moves on them.