-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add closeOtherTabs
, closeTabsAfter
actions
#7176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-Settings
Issues related to settings and customizability, for console or terminal
Area-UserInterface
Issues pertaining to the user interface of the Console or Terminal
Issue-Task
It's a feature request, but it doesn't really need a major design.
Product-Terminal
The new Windows Terminal.
labels
Aug 4, 2020
8 tasks
miniksa
reviewed
Aug 4, 2020
miniksa
reviewed
Aug 4, 2020
miniksa
reviewed
Aug 4, 2020
miniksa
reviewed
Aug 4, 2020
This was referenced Aug 4, 2020
miniksa
approved these changes
Aug 6, 2020
DHowett
approved these changes
Aug 6, 2020
zadjii-msft
added
the
AutoMerge
Marked for automatic merge by the bot when requirements are met
label
Aug 6, 2020
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Settings
Issues related to settings and customizability, for console or terminal
Area-UserInterface
Issues pertaining to the user interface of the Console or Terminal
AutoMerge
Marked for automatic merge by the bot when requirements are met
Issue-Task
It's a feature request, but it doesn't really need a major design.
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds support for two actions,
closeOtherTabs
andcloseTabsAfter
. Both these actions accept anindex
parameter.closeOtherTabs
: Close tabs other thanindex
closeTabsAfter
: Close tabs afterindex
(This is also "Close tabs to the right")References
PR Checklist
index
param tocloseTab
" to add similar support to the close tab actionindex
param tocloseOtherTabs
,closeTabsAfter
optional" to make them both work on the active tab when there's noindex
providedValidation Steps Performed
index
'th tab selected works as expectedindex
'th tab selected works as expectedindex
'th tab selected works as expectedindex
'th tab selected works as expectedindex
param, then the tabs will expand to fill the entire width of the tab row, until you mouse over them. Probably has something to do with tabs not resizing down until there's a mouse exit event.