Keep on top feature #6494

Chips1234 · 2020-06-13T20:14:48Z

Summary of the Pull Request

Makes a button on the title bar to keep up on top of other windows. Calculator has a similar feature.
Please note, as of 06/13, the button design is finished but the code is not even started. This is a work in progress.

References

Connected to #3038.

PR Checklist

Closes Feature Request: Always On Top #3038
CLA signed. If not, go over here and sign the CLA
No documents

Syncing fork to repo

…resources) Tooltip Text from Resources.resw Files

…resources)-1 Tooltip Text for New Tab Split Button

I have made the basic desgin for the button to keep on top (Placement seem to be off tho, any help would be welcome)

Chips1234 · 2020-06-13T20:16:40Z

For some reason, there are always commits unrelated to this PR. So, please ignore the commits from Apr 17th, to May 24th. Only beginning on 30 June 2020.

Chips1234 · 2020-06-13T20:18:04Z

Also, can someone help with the placement of the button? It looks good in the designer but it actually is placed on top of the "New Tab" split button

AnuthaDev

Add another columndefinition with width auto and change the column of minmaxclosecontrol to 3 and you should be good.

AnuthaDev · 2020-06-14T06:51:32Z

src/cascadia/TerminalApp/TitlebarControl.xaml

+        MinWidth="46.0"
+        Width="46.0"
+        Height="36"
+        Margin="220,0,0,0"


This should be removed. Generally you should not hardcode margins

AnuthaDev · 2020-06-14T06:52:01Z

src/cascadia/TerminalApp/TitlebarControl.xaml

+        UseLayoutRounding="True"
+        HorizontalAlignment="Right"
+        VerticalAlignment="Stretch"
+        Grid.Row="2"/>


Replace it with Grid.Column="2"

AnuthaDev · 2020-06-14T06:55:40Z

For some reason, there are always commits unrelated to this PR. So, please ignore the commits from Apr 17th, to May 24th. Only beginning on 30 June 2020.

Squash changes and force push :)

AnuthaDev · 2020-06-14T06:57:09Z

~~Also, this button should preferably be a part of the minmaxclosecontrol so it can reuse the styles and maybe even code~~

Nope, that control isn't necessarily always visible

AnuthaDev · 2020-06-14T07:26:22Z

We might even want to make a separate control, so that (optional?) features like #5426 and #3038 can be implemented together

Chips1234 · 2020-06-14T17:41:17Z

Alright, thanks!

Chips1234 · 2020-06-14T17:42:50Z

We might even want to make a separate control, so that (optional?) features like #5426 and #3038 can be implemented together

Alright.

Chips1234 · 2020-06-14T22:45:17Z

If I set the value for the button for Grid.column="2" and for the MinMaxClose Grid.Column="3", the button overlaps the minimize one.

zadjii-msft · 2020-06-15T11:20:01Z

Thanks for the effort! I think I'd prefer if we started by coming at this from another direction. I think it would be better to prove that we can get the Terminal to be set to "keep on top" mode first, then add the UI for enabling that setting. IMO, I'd rather this just be a setting that's enabled in the settings UI (#1564), or toggled with a keybinding/command, rather than have a dedicated button for it. So, if I were implementing this, I'd probably do it in the following steps:

First prove that I can get the Terminal to stay on top of all windows.
Then I'd add a setting to enable this fuctionality
THen I'd make sure that the setting can be hot-reloaded, so the value can be turned on/off at runtime.
If a follow-up PR, I'd add a ShortcutAction to manually toggle that setting.

AnuthaDev · 2020-06-15T11:32:37Z

IMO, I'd rather this just be a setting that's enabled in the settings UI (#1564), or toggled with a keybinding/command, rather than have a dedicated button for it.

I would prefer it like the calculator with a dedicated button in titlebar to change always on top status along with a keyboard shortcut to toggle the always on top flag. IMHO, you should rather add a setting to set whether or not to show the "always on top" button in titlebar

AnuthaDev · 2020-06-15T11:33:44Z

Also, it is interesting to think how this feature would interact with tab tearoff when it is implemented...

zadjii-msft · 2020-06-15T12:10:28Z

Also, it is interesting to think how this feature would interact with tab tearoff when it is implemented...

That's exactly what my question was when this issue was first posted:

I suppose my next question would be: what happens when multiple applications want to be "always on top" - who wins?

and I'm not sure I've gotten a totally satisfactory answer to that question yet.

> I would prefer it like the calculator with a dedicated button in titlebar to change always on top status along with a keyboard shortcut to toggle the always on top flag. IMHO, you should rather add a setting to set whether or not to show the "always on top" button in titlebar

I've been highly reluctant to add more buttons to our already pretty minimalistic UI. It starts a slippery slope - "if this button is okay, then why can't I have a button dedicated to each profile"? I worry that adding more dedicated UI elements like this would leave the UI looking cluttered. Hence why I'm trying to drive the Command Palette (see #2046) for adding commands in a toggleable menu, and also why I'm driving to allow the user to add actions directly to the "New Tab Button dropdown" (see spec in-progress #5888). That seems like a much better place to stash this button, if the user so chooses. Hence my push to have this be a ShortcutAction the user can toggle 😉.

WSLUser · 2020-06-15T13:30:37Z

I just did some playing around using the Keep on Top feature in Calculator. I'll be honest, I'm not a huge fan of it. There's an ugly button right next to the Calculator Mode title and it always goes to the right. I actually prefer having it done exactly as zadjii-msft requests. Another thing to think about in regards to that ShortcutAction: how will that play into Quake Mode? Will we be able to instantly place Terminal on top (toggable setting) when we launch it?

AnuthaDev · 2020-06-15T15:21:35Z

Also, should there be a maximum size limit in AOT mode?...

ZhaoMJ · 2020-06-22T23:59:07Z

Given PowerToys has a prototype of "always on top" tool, we might not need to implement it by ourselves. So we can keep our UI minimalistic. I also think they can figure out a solution for cases like multiple windows.

WSLUser · 2020-07-06T13:36:27Z

In some world where somebody chooses to use Windows Terminal but not Power Toys, we'd need this feature available as an option that defaults to false. I am a bit worried about conflicts between trying to use the same feature via both Terminal settings and PowerToys but I think that's simply a doc update that recommends users not to enable it in both but one or the other.

ghost · 2020-07-13T15:00:15Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

zadjii-msft · 2020-07-13T19:13:47Z

Thanks for the contribution! Since this PR seems to be a bit stale now, we're going to close this in favor of #6903. Thanks!

Chips1234 · 2020-07-13T19:24:09Z

Alright, thanks

Chips1234 and others added 8 commits April 17, 2020 15:47

Merge pull request #1 from microsoft/master

8a076bc

Syncing fork to repo

Added tooltip text for MinMaxCloseControl

c044f53

Merge pull request #1 from Chips1234/dev/chips1234/tooltip-text(from-…

e96de7e

…resources) Tooltip Text from Resources.resw Files

Tooltip Text for New Tab Split Button

a139c7b

Merge pull request #2 from Chips1234/dev/chips1234/tooltip-text(from-…

62751c1

…resources)-1 Tooltip Text for New Tab Split Button

Merge remote-tracking branch 'upstream/master'

7ff46af

Merge remote-tracking branch 'upstream/master'

dc40b86

Made the basic design of button

956f9e9

I have made the basic desgin for the button to keep on top (Placement seem to be off tho, any help would be welcome)

ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jun 13, 2020

AnuthaDev suggested changes Jun 14, 2020

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 14, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 14, 2020

zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 6, 2020

ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jul 13, 2020

zadjii-msft closed this Jul 13, 2020

ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jul 13, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep on top feature #6494

Keep on top feature #6494

Chips1234 commented Jun 13, 2020

Chips1234 commented Jun 13, 2020 •

edited

Loading

Chips1234 commented Jun 13, 2020

AnuthaDev left a comment

AnuthaDev Jun 14, 2020

AnuthaDev Jun 14, 2020

AnuthaDev commented Jun 14, 2020

AnuthaDev commented Jun 14, 2020 •

edited

Loading

AnuthaDev commented Jun 14, 2020

Chips1234 commented Jun 14, 2020

Chips1234 commented Jun 14, 2020

Chips1234 commented Jun 14, 2020

zadjii-msft commented Jun 15, 2020

AnuthaDev commented Jun 15, 2020

AnuthaDev commented Jun 15, 2020

zadjii-msft commented Jun 15, 2020

WSLUser commented Jun 15, 2020 •

edited

Loading

AnuthaDev commented Jun 15, 2020

ZhaoMJ commented Jun 22, 2020

WSLUser commented Jul 6, 2020

ghost commented Jul 13, 2020

zadjii-msft commented Jul 13, 2020

Chips1234 commented Jul 13, 2020 via email •

edited by ghost

Loading

Keep on top feature #6494

Keep on top feature #6494

Conversation

Chips1234 commented Jun 13, 2020

Summary of the Pull Request

References

PR Checklist

Chips1234 commented Jun 13, 2020 • edited Loading

Chips1234 commented Jun 13, 2020

AnuthaDev left a comment

Choose a reason for hiding this comment

AnuthaDev Jun 14, 2020

Choose a reason for hiding this comment

AnuthaDev Jun 14, 2020

Choose a reason for hiding this comment

AnuthaDev commented Jun 14, 2020

AnuthaDev commented Jun 14, 2020 • edited Loading

AnuthaDev commented Jun 14, 2020

Chips1234 commented Jun 14, 2020

Chips1234 commented Jun 14, 2020

Chips1234 commented Jun 14, 2020

zadjii-msft commented Jun 15, 2020

AnuthaDev commented Jun 15, 2020

AnuthaDev commented Jun 15, 2020

zadjii-msft commented Jun 15, 2020

WSLUser commented Jun 15, 2020 • edited Loading

AnuthaDev commented Jun 15, 2020

ZhaoMJ commented Jun 22, 2020

WSLUser commented Jul 6, 2020

ghost commented Jul 13, 2020

zadjii-msft commented Jul 13, 2020

Chips1234 commented Jul 13, 2020 via email • edited by ghost Loading

Chips1234 commented Jun 13, 2020 •

edited

Loading

AnuthaDev commented Jun 14, 2020 •

edited

Loading

WSLUser commented Jun 15, 2020 •

edited

Loading

Chips1234 commented Jul 13, 2020 via email •

edited by ghost

Loading