Bugfix: don't allow closing last tab with middle click #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also add a few of the TODOs for similar areas)
miniksa
requested changes
May 10, 2019
|
TODOs reference #627. Just preventing closing the last tab, for now. |
DHowett-MSFT
approved these changes
May 10, 2019
miniksa
approved these changes
May 10, 2019
ReneeGA2020
pushed a commit
to ReneeGA2020/Terminal
that referenced
this pull request
May 11, 2019
* Bugfix: don't allow closing last tab with middle click (Also add a few of the TODOs for similar areas) * Replaced MSFT TODO with GitHub TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a few of the TODOs for similar areas. This change will do for now until we decide on a better story for closing the last tab.