Use modern loops #5152
Closed
Use modern loops #5152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Mar 30, 2020
| @@ -80,9 +80,8 @@ void TextAttributeTests::TestRoundtripMetaBits() | |||
| COMMON_LVB_UNDERSCORE | |||
| }; | |||
|
|
|||
| for (int i = 0; i < ARRAYSIZE(metaFlags); ++i) | |||
| for (unsigned short flag : metaFlags) | |||
There was a problem hiding this comment.
I had no idea that this just worked in c++, that's really cool.
There was a problem hiding this comment.
It does except the main problem is for some reason in the tracelogging .cpp, I had to unroll the changes because of what I think is a compiler bug because only in that file would the compiler emit an error.
miniksa
reviewed
Mar 30, 2020
| @@ -1055,14 +1055,14 @@ void InputEngineTest::VerifySGRMouseData(const std::vector<std::tuple<SGR_PARAMS | |||
| SGR_PARAMS input; | |||
| MOUSE_EVENT_PARAMS expected; | |||
| INPUT_RECORD inputRec; | |||
| for (size_t i = 0; i < testData.size(); i++) | |||
| for (const auto& i : testData) | |||
There was a problem hiding this comment.
Can this not be for (const auto& [sgrParam, mouseEventParam]) : testData to split the tuple up all at once and skip the std::get?
DHowett-MSFT
reviewed
Apr 2, 2020
| // Return value: | ||
| // - none | ||
| // Note: may throw exception on allocation error | ||
| void SCREEN_INFORMATION::AddTabStop(const SHORT sColumn) |
There was a problem hiding this comment.
there may have been a merge conflict -- this reintroduces the tab stop functions that were deleted in master
added 8 commits
April 29, 2020 13:30
This was referenced Jun 5, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
I converted many of the older loops to the modern one, which is much shorter and is easier to understand.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed