Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startup task, setting to launch application on login #4908
Add startup task, setting to launch application on login #4908
Changes from 23 commits
724d08f
273956a
72a0bc1
6423c97
35dcdb1
9a84eac
59e964c
db9d89c
c282610
99f7813
91669b9
4438c27
99fc071
6ca9137
e04de3f
52a6920
8d740b7
eb220fc
b0cb771
cae7c06
08284bd
50c01ea
07f3434
f30195a
2ab2b47
884116c
39c9feb
a783e45
76936d9
fc1a555
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably need to get a weak ref to
this
before theco_await
, and make sure you can get a strong ref afterwards to make sure thatthis
is still alive.We do a lot of that in
TerminalPage
like so:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to put that change in. Why is there the need to get the weak this ref? The other
fire_and_forget
routines in the same class don't follow that same pattern -- does it make sense to create an issue to refactor those to grab the weak refs as well?ex in AppLogic:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular one we're less worried about.
AppLogic
controls the lifetime of the entire application, so it's actually never going away, and we don't need to really worry about it. Though, you're right that it wouldn't hurt to do the right thing there as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #6295 to track it