Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a rampant crash in TSFInputControl when opening new tabs #4830

Merged
7 commits merged into from
Mar 7, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

We're deref'ing a null _terminal. Don't do that. This is a okay fix, mostly to stem the bleeding. @DHowett-MSFT's got a mind for a real fix to #4166, but this isn't it.

PR Checklist

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU

@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 7, 2020
@ghost
Copy link

ghost commented Mar 7, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 56 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member

miniksa commented Mar 7, 2020

@msftbot wait 1 second

@ghost
Copy link

ghost commented Mar 7, 2020

Hello @miniksa!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@miniksa
Copy link
Member

miniksa commented Mar 7, 2020

@msftbot wait 1 minute

@ghost
Copy link

ghost commented Mar 7, 2020

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Sat, 07 Mar 2020 03:19:36 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 852f0aa into master Mar 7, 2020
@ghost ghost deleted the dev/migrie/b/4613-its-nice-to-win-one branch March 7, 2020 03:20
@ghost
Copy link

ghost commented Mar 17, 2020

🎉Windows Terminal Preview v0.10.761.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants