Conhost: copy RTF to clipboard #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTF data is now copied to the clipboard. The clipboard format name used for RTF data is `Rich Text Format`. Refactored some code in `Clipboard.cpp` so that code for setting data to the clipboard is re-used. Also, renamed parameter `fAlsoCopyHtml` to `fAlsoCopyFormatting` to make it more generic. Tested by copying text from console to WordPad. Also verified that HTML copy is not regressed by copying to Word.
|
Please review! @carlos-zamora @DHowett-MSFT |
carlos-zamora
requested changes
Nov 22, 2019
carlos-zamora
approved these changes
Nov 25, 2019
zadjii-msft
approved these changes
Dec 4, 2019
zadjii-msft
approved these changes
Dec 5, 2019
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTF data is now copied to the clipboard. The clipboard format name
used for RTF data is
Rich Text Format.Refactored some code in
Clipboard.cppso that the code for settingdata to the clipboard is re-used. Also, renamed parameter
fAlsoCopyHtmltofAlsoCopyFormattingto make it more generic.Tested by copying text from console to WordPad. Also verified that
HTML copy is not regressed by copying to Word.
Closes #3560.