Lead the user to the AI settings when no provider is set up #18121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto dev/pabhoj/featurellm_openai
# Conflicts: # src/cascadia/TerminalSettingsEditor/AISettingsViewModel.h # src/cascadia/TerminalSettingsEditor/AISettingsViewModel.idl # src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Co-authored-by: Heiko <61519853+htcfreek@users.noreply.github.com>
| @@ -177,6 +177,14 @@ | |||
| <value>Assistant</value> | |||
| <comment>A string to represent the section that the chat assistant typed, presented when the user exports the chat history to a file</comment> | |||
| </data> | |||
| <data name="SetUpProviderDisclaimer.Text" xml:space="preserve"> | |||
| <value>You have not set up an AI provider yet! Set one up in the settings</value> | |||
| <comment>asfsadf</comment> | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| </data> | ||
| <data name="SetUpProviderButton.Text" xml:space="preserve"> | ||
| <value>Set up AI provider</value> | ||
| <comment>afsdf</comment> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
PankajBhojwani
commented
Oct 29, 2024
| @@ -5730,6 +5734,9 @@ namespace winrt::TerminalApp::implementation | |||
| _extensionPalette.ActiveCommandline(L""); | |||
| } | |||
| }); | |||
| _extensionPalette.SetUpProviderInSettingsRequested([&](IInspectable const&, IInspectable const&) { | |||
| OpenSettingsUI(L"AISettings_Nav"); | |||
There was a problem hiding this comment.
A little annoying to hard code this string here - we might want to eventually have an enum for each possible nav page
DHowett
approved these changes
Oct 29, 2024
Base automatically changed from
dev/pabhoj/featurellm_registry_enable
to
feature/llm
October 29, 2024 01:41
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zadjii-msft
approved these changes
Oct 29, 2024
| @@ -34,6 +34,7 @@ namespace Microsoft.Terminal.Settings.Editor | |||
| [default_interface] runtimeclass MainPage : Windows.UI.Xaml.Controls.Page, IHostedInWindow | |||
| { | |||
| MainPage(Microsoft.Terminal.Settings.Model.CascadiaSettings settings); | |||
| String StartingPage; | |||
There was a problem hiding this comment.
There's notes scattered throughout
- Tab tearout for Settings page loses current page #18012
- Process Model v3 / Tab tear-out ship list #14957
- Saving settings moves/looses focus to Startup item #15600
of things that this might help us fix. Nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user opens up Terminal Chat but does not have a provider set up, provide a button that sends them to the relevant settings page