Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor inheritance #17576

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix cursor inheritance #17576

merged 1 commit into from
Jul 17, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jul 17, 2024

#17574 had 2 bugs, which I failed to notice because I didn't test
the code again after fixing the WaitUntilDSR boolean expression:

  • The VtInputThread needs to be running in order
    for us to see any VT input get parsed.
    • Consequentially, the console lock must be suspended while we wait.
  • Since WaitUntilDSR didn't detect timeouts it would loop forever.
    This wasn't obvious before, because it wouldn't loop at all. (lol)

@lhecker lhecker added Product-Conpty For console issues specifically related to conpty Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jul 17, 2024
@DHowett DHowett merged commit 1feb56e into main Jul 17, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/17510-fix-cursor-inheritance branch July 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conpty For console issues specifically related to conpty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @DHowett @zadjii-msft