Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix being unable to delete a changed Font Axis or Font Feature #16790

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Feb 29, 2024

Make sure the delete button's Tag updates when the selected axis/feature changes, so that the correct key value gets propagated when the delete button is clicked.

Refs #16678 #16104

Validation Steps Performed

  1. Add a new feature/axis
  2. Change the key
  3. Click the delete button
  4. Delete button works

@zadjii-msft zadjii-msft merged commit ec5d246 into main Mar 1, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/pabhoj/sui_font_fix branch March 1, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants