Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Microsoft.Windows.ImplementationLibrary to 1.0.240122.1 #16617

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Upgrade Microsoft.Windows.ImplementationLibrary to 1.0.240122.1 #16617

merged 3 commits into from
Jan 31, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jan 29, 2024 •
edited
Loading

This includes a fix for the hang on shutdown due to the folder change reader.

WIL now validates format strings in LOG... macros (yay!) and so we needed to fix
some of our LOG macros.

Closes #16456

@DHowett
Upgrade Microsoft.Windows.ImplementationLibrary to 1.0.240122.1
11b1566 
This includes a fix for the hang on shutdown due to the folder change
reader.

Closes #16456
@DHowett DHowett enabled auto-merge (squash) January 29, 2024 19:18
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Area-Windowing Window frame, quake mode, tearout Product-Terminal The new Windows Terminal. labels Jan 29, 2024
@DHowett DHowett disabled auto-merge January 29, 2024 19:25
@DHowett DHowett enabled auto-merge (squash) January 29, 2024 19:25
@DHowett DHowett merged commit ce30e7c into main Jan 31, 2024
20 checks passed
@DHowett DHowett deleted the dev/duhowett/wil-24 branch January 31, 2024 00:01
DHowett added a commit that referenced this pull request Feb 21, 2024
@DHowett
Upgrade Microsoft.Windows.ImplementationLibrary to 1.0.240122.1 (#16617)
427135a 
This includes a fix for the hang on shutdown due to the folder change
reader.

WIL now validates format strings in `LOG...` macros (yay!) and so we
needed to fix some of our `LOG` macros.

Closes #16456

(cherry picked from commit ce30e7c)
Service-Card-Id: 91892152
Service-Version: 1.20
DHowett added a commit that referenced this pull request Feb 26, 2024
@DHowett
Upgrade Microsoft.Windows.ImplementationLibrary to 1.0.240122.1 (#16617)
bb5f56e 
This includes a fix for the hang on shutdown due to the folder change
reader.

WIL now validates format strings in `LOG...` macros (yay!) and so we
needed to fix some of our `LOG` macros.

Closes #16456

(cherry picked from commit ce30e7c)
Service-Card-Id: 91923199
Service-Version: 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

Assignees
No one assigned
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
1.19 Servicing Pipeline
Status: Shipped
1.20 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WindowsTerminal.exe leak (never exit) after the wtd.exe new-tab ... command line process exits.
3 participants
@DHowett @lhecker @PankajBhojwani