-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade fmt to 11.0.2 #16007
Upgrade fmt to 11.0.2 #16007
Conversation
Should we hold off on this PR until after the 1.19 release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hold off on this PR until after the 1.19 release?
Yup! I'll block it.
I would also prefer to (as mentioned before) switch to vcpkg before introducing another copy/paste of some OSS code 😄 |
I'm moving this to draft for now to get it out of the queue.
We'd all love for vcpkg to like, be a good package manager, but that's probably not a viable reason to block this for now. |
d283b28
to
d9a8198
Compare
d9a8198
to
f651930
Compare
f651930
to
02a8dbd
Compare
02a8dbd
to
5c2645d
Compare
This comment has been minimized.
This comment has been minimized.
Minor issue in that fmt 11 isn't in the vcpkg ports repo yet. That should be an easy fix. :) |
This comment has been minimized.
This comment has been minimized.
I reviewed the entire diff again and I believe it's correct. However, I just noticed that this contains all of my |
i'm OK keeping it honestly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks!
Between fmt 7.1.3 and 11.0.2 a lot has happened.
wchar_t
support isnow more limited and implicit conversions don't work anymore.
Furthermore, even the non-
FMT_COMPILE
API is now compile-time checkedand so it fails to work in our UI code which passes
hstring
formatstrings which aren't implicitly convertible to the expected type.
fmt::runtime
was introduced for this but it also fails to work forhstring
parameters. To solve this, a newRS_fmt
macro was addedto abstract the added
std::wstring_view
casting away.Finally, some additional changes to reduce
stringstream
usagehave been made, whenever
format_to
, etc., is available.This mostly affects
ActionArgs.cpp
.Closes #16000
Validation Steps Performed