AtlasEngine: Fix cursor invalidation for BackendD2D #15427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
May 25, 2023
zadjii-msft
approved these changes
May 25, 2023
DHowett
pushed a commit
that referenced
this pull request
May 25, 2023
TIL: `CreateCompatibleRenderTarget` does not initialize the bitmap it returns. You got to do that yourself just like in D3D. ## Validation Steps Performed * Set `ATLAS_DEBUG_FORCE_D2D_MODE` to 1 * Changing the cursor in the settings immediately updates it ✅ (cherry picked from commit 7650ecf) Service-Card-Id: 89323214 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL:
CreateCompatibleRenderTargetdoes not initialize the bitmapit returns. You got to do that yourself just like in D3D.
Validation Steps Performed
ATLAS_DEBUG_FORCE_D2D_MODEto 1