Remove the window thread from the list of threads before nulling the AppHost #15231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DHowett
approved these changes
Apr 24, 2023
|
I'm afraid of these "maybe it fixes it????" changes with the lack of having repros, but I get it! |
lhecker
approved these changes
Apr 24, 2023
|
|
||
| void WindowThread::RundownForExit() | ||
| { | ||
| _host = nullptr; |
There was a problem hiding this comment.
Alternatively, (re)move the _host = nullptr?
|
Unfortunately, this PR didn't seem to have fixed the issue. While mucking around with 2 tabs, changing order without letting go of them, actually changing their order, dragging into a new window, dragging back into the old window, but not actually, then actually, etc., I had an A/V in the exact same spot. The top most part of the stack trace shows how it's caused by an async action (I think?) inside XAML trying to access an UI element that doesn't exist anymore (I think?).
For a double whammy of despair, I'd like to direct your attention to how it uses an IPC system for in-proc calls, because the objects are agile. Might as well use HTTP via localhost. Here's the full stack trace: |
6 tasks
|
Exact same spot? I dunno about that - the stack you've got there is quite a bit different than the one in MSFT:43995981. I'm fine calling it an issue, but I'll track it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14957 (comment).
I think there's a race here that lets the WindowEmperor muck around with the window after it's done, but before we remove it from our list of threads.
This should remove the thread from the list, then null out the AppHost, then flush the XAML queue, preventing the A/V.
Closes MSFT:43995981