Use DIPs for the window bounds when tearing out #15094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
approved these changes
Apr 3, 2023
DHowett
approved these changes
Apr 3, 2023
lhecker
reviewed
Apr 3, 2023
Comment on lines
1285
to
1290
| static_cast<float>(dragPositionInPixels.y), | ||
| static_cast<float>(windowSize.width), | ||
| static_cast<float>(windowSize.height) }; | ||
| rect = winrt::Windows::Foundation::Rect{ inDips.to_winrt_rect() }; | ||
| windowBoundsReference = rect; |
There was a problem hiding this comment.
Just windowBoundsReference = inDips.to_winrt_rect(); should be fine I think.
DHowett
reviewed
Apr 3, 2023
| // Convert to DIPs for the size, so that dragging across a DPI boundary | ||
| // retains the correct dimensions. | ||
| const auto sizeInDips = windowSize.scale(til::math::rounding, 1.0f / scale); | ||
| til::rect inDips{ dragPositionInPixels, sizeInDips }; |
There was a problem hiding this comment.
should the drag position be DIP'd as well? after all... we use it for positioning
There was a problem hiding this comment.
Yea this is weird - we already know exactly the pixel location we want the window to open at. We don't want a position to scale based off the resolution of the target display.
We could theoretically get the scale of the target display and unscale the position to DIPs then scale back, but that doesn't seem valuable? 🤷
DHowett
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where you'd drag across the boundary and the new window would be at the wrong size
related to #14957