Fix drag and drop on '+' button for drive letters #10842
Conversation
| @@ -255,10 +255,10 @@ namespace winrt::TerminalApp::implementation | |||
|
|
|||
| std::wstring pathText = path.wstring(); | |||
|
|
|||
| // Handle edge case of "C:\\", seems like the "StartingDirectory" doesn't like path which ends with '\' | |||
There was a problem hiding this comment.
I'm actually quite surprised by this premise. The reason we have issues with StartingDirectory when passed through the commandline are ones of escaping.
Does it really beef it if we don't do this trick at all? huh.
There was a problem hiding this comment.
(because the commandline escaping for wt results in "C:\" being parsed as C:\" (terminating quote captured in path))
There was a problem hiding this comment.
Yes - this is purely for the "Open in new window" case
If I comment out the pathText.push_back(L'.') and drop on C:\ with shift pressed, the new window fails to parse the command line:
There was a problem hiding this comment.
Drag and dropping C:\ to get a new tab or split the current window works fine, it's just the new window case that fails.
There was a problem hiding this comment.
OH. Okay.
We should fix this in the New Window commandline generator, honestly. That would also fix it for shift-clicking the cmd2 profile I created to test this. 😄
I suspect that this code lives in NewTerminalArgs::ToCommandline.
There was a problem hiding this comment.
Done - with the added bonus that this now has a test 🙂
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
Fixes dragging and dropping drive letters onto the '+' button.
Manually tested - dragging and dropping the
C:\drive onto the '+' button works when creating a new tab, splitting or creating a new window. Dragging and dropping a regular directory still works.Closes #10723