Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Settings context menu still uses the BIG close icon #9317

Closed
zadjii-msft opened this issue Mar 1, 2021 · 3 comments · Fixed by #9324
Closed

The Settings context menu still uses the BIG close icon #9317

zadjii-msft opened this issue Mar 1, 2021 · 3 comments · Fixed by #9324
Assignees
@carlos-zamora
Labels
Area-SettingsUI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

The Settings context menu still uses the old icon.
closeicon2
Wouldn't it be better to have a single menu for all tabs?

Originally posted by @gabrielconl in #8419 (comment)

Originally fixed in #8424, but not for SettingsTab. Really should be fixed in TabBase
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 1, 2021
@zadjii-msft zadjii-msft added Area-SettingsUI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 1, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 1, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 1, 2021
@zadjii-msft
Copy link
Member Author

Tossing this in 2.0, since this is a p3 bug.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 1, 2021
@carlos-zamora carlos-zamora mentioned this issue Mar 2, 2021
Merged
@carlos-zamora carlos-zamora self-assigned this Mar 2, 2021
@ghost ghost added the In-PR This issue has a related PR label Mar 2, 2021
@ghost ghost closed this as completed in #9324 Mar 4, 2021
ghost pushed a commit that referenced this issue Mar 4, 2021
@carlos-zamora
Change SettingsTab close icon to be smaller (#9324)
4a95341 
We were using the wrong close icon for the settings tab. This is a side effect of `TerminalTab` overriding `TabBase`'s implementation.

#6800 - Settings UI Epic

Closes #9317
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 4, 2021
DHowett pushed a commit that referenced this issue Mar 15, 2021
@carlos-zamora @DHowett
Change SettingsTab close icon to be smaller (#9324)
cd68bd0 
We were using the wrong close icon for the settings tab. This is a side effect of `TerminalTab` overriding `TabBase`'s implementation.

#6800 - Settings UI Epic

Closes #9317

(cherry picked from commit 4a95341)
DHowett pushed a commit that referenced this issue Mar 15, 2021
@carlos-zamora @DHowett
Change SettingsTab close icon to be smaller (#9324)
fb4dab0 
We were using the wrong close icon for the settings tab. This is a side effect of `TerminalTab` overriding `TabBase`'s implementation.

#6800 - Settings UI Epic

Closes #9317

(cherry picked from commit 4a95341)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9324, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9324, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-SettingsUI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Change SettingsTab close icon to be smaller microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft