Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing behavior in Command Palette when pressing "Home" during search #8191

Closed
Don-Vito opened this issue Nov 7, 2020 · 3 comments · Fixed by #8194
Closed

Confusing behavior in Command Palette when pressing "Home" during search #8191

Don-Vito opened this issue Nov 7, 2020 · 3 comments · Fixed by #8194
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 7, 2020

Environment

Development branch

Steps to reproduce

  1. Open command palette.
  2. Input some search text
  3. Scroll Down a bit
  4. Now press home
  5. Press home again

ConfusingHome

Expected behavior

Home should be disabled either in search box or in the command palette.
Same of course applies to End.

Actual behavior

  1. The first occurrence of Home goes to the beginning of the filter
  2. The second occurrence of Home scrolls the palette
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 7, 2020
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Nov 8, 2020

@Hegunumo - I also opened this. Please let me know how you see it.

@ghost ghost mentioned this issue Nov 8, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 8, 2020
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Nov 8, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 8, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Nov 8, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 9, 2020
@KevinCathcart
Copy link

For what is it worth, it looks (from experimentation) like VSCode does the following:

Horizontal navigation commands like ← or Home affect the text box. Vertical navigation commands like ↓,PgUp, or Ctrl+Home affect the list.

That seems to me to be a logical way to differentiate without losing functionality. Of course, how to actually implement that cleanly may still be an open question.

@ghost ghost closed this as completed in #8194 Nov 30, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 30, 2020
ghost pushed a commit that referenced this issue Nov 30, 2020
@kaihugo
Disable Home and End keys in Command Palette search box (#8194)
9cffe27 
Home/End will only navigate the command palette list when the user holds down Ctrl.

Closes #8191
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8194, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Disable Home and End keys in Command Palette search box
4 participants
@KevinCathcart @DHowett @Don-Vito @zadjii-msft