Needs to input twice to insert a single Chinese symbol #3745

hez2010 · 2019-11-27T14:00:25Z

Environment

Windows build number: 18363.476
Windows Terminal version (if applicable): 0.7.3291.0

Steps to reproduce

switch to Microsoft Chinese Input Method
press shift + / to insert a Chinese ？

Expected behavior

？ successfully inserted

Actual behavior

I have to press shift + / twice to insert a single ？

Same problem with other Chinese symbols, such as 《, 》, 【, 】 and etc.

The text was updated successfully, but these errors were encountered:

spindensity · 2019-11-28T01:43:02Z

Same problem here, need to press the corresponding key twice to input one Chinese punctuation.

Windows terminal 0.7.3291.0

mkitzan · 2019-11-30T21:41:18Z

I found an interesting pattern when repro-ing this issue. The double-input behavior can be repro-ed with any character by performing the following:

Set language to Chinese
Open new WT instance
Enter question mark (this first question mark should print to screen fine)
Enter any character, C1 (C1 will not be printed to screen)
Enter any character, C2 (C2 will be printed to screen, possibly C1 too depending on its character)

Based off this behavior, it appears that after entering certain characters (like question mark), WT is in a buggy state which on transition out of that state the character is consumed and not printed. ~~I wonder if the issue is in one of the StateMachine classes or TerminalInput.~~

Interesting to note that this is not a problem with the Japanese language package.

mkitzan · 2019-11-30T22:59:44Z

In TSFInputControl.cpp, the CoreTextEditContext is becoming desynced on the CompositionCompleted event when _inputBuffer and _textBlock are cleared but the NotfiyTextChanged/NotifySelectionChanged fail (or there's a lag) to update the server. Because of this, the caret is not reset to 0,0 on the start of a new composition leading to the out_of_range exception. After catching the exception, CoreTextTextUpdatingResult::Failed is sent which causes the server to finally pick up the update from NotfiyTextChanged/NotifySelectionChanged.

Exception thrown at 0x00007FFB872CA839 in WindowsTerminal.exe: Microsoft C++ exception: std::out_of_range at memory location 0x0000005CE78FE150.
Exception thrown at 0x00007FFB872CA839 in WindowsTerminal.exe: Microsoft C++ exception: [rethrow] at memory location 0x0000000000000000.
C:\GitHub\terminal-fork\src\cascadia\TerminalControl\TSFInputControl.cpp(328)\TerminalControl.dll!00007FFB46C165CD: (caller: 00007FFB46BE1CAD) LogHr(1) tid(42cc) 8000000B The operation attempted to access data outside the valid range
    Msg:[std::exception: invalid string position]

mkitzan · 2019-12-01T21:18:41Z

The actual call to NotifyTextChanged appears malformed because the first argument should be the modified range ie the entire _inputBuffer range. However, the corrected function call still doesn't update the CoreTextEditContext server. I wonder if NotifyTextChanged can only be called outside of a CoreTextEditContext handler.

mkitzan · 2019-12-02T02:55:15Z

Because CoreTextEditContext is not behaving as expected, could just implement the Caret and Selection ourselves and use the CoreTextEditContext events to receive text and composition start/complete signals. It would be pretty hacky, but I haven't been able to find a clean fix. Maybe someone who has more experience with UWP custom text input would have some insight into a solution.

zadjii-msft · 2019-12-02T14:56:36Z

@mkitzan thanks for the investigation! I'm pretty sure that @philnach might be interested in your findings

lhecker · 2020-01-06T23:55:35Z

@zadjii-msft If you change this:

terminal/src/cascadia/TerminalControl/TSFInputControl.cpp

Lines 227 to 228 in 4882917

    
           _editContext.NotifyTextChanged(emptyTextRange, 0, emptyTextRange); 
        
           _editContext.NotifySelectionChanged(emptyTextRange);

...into this:

_editContext.NotifyFocusLeave();
_editContext.NotifyTextChanged(emptyTextRange, 0, emptyTextRange);
_editContext.NotifyFocusEnter();

...this issue and #3706 (and others?) should be fixed. 🙂 And #3645 is probably void too, because it seems to work even if you comment this out:

terminal/src/cascadia/TerminalControl/TSFInputControl.cpp

Line 107 in 4882917

    
           // _editContext.NotifyFocusLeave(); TODO GitHub #3645: Enabling causes IME to no longer show up, need to determine if required

Would you like me to submit a PR tomorrow?

zadjii-msft · 2020-01-07T13:43:01Z

@lhecker I would love a PR from you 😄

lhecker · 2020-01-07T13:56:27Z

Oh I just noticed that NotifyTextChanged() is being used incorrectly anyways. The first argument is supposed to be the range that's modified. In this case it would be [0, the_previous_buffer_length] instead of [0, 0]. I'll try fixing this later today.

@DHowett-MSFT

The first argument to `NotifyTextChanged` incorrectly was `[0,0]` instead of the length of the text to be removed from the `CoreTextEditContext`. Best source of documentation for `NotifyTextChanged`: https://docs.microsoft.com/en-us/windows/uwp/design/input/custom-text-input#overriding-text-updates FYI @DHowett-MSFT (just in case): C++/WinRT uses `winrt::param::hstring` for string parameters which intelligently borrows strings. As such you can simply pass a `std::wstring` to most WinRT methods without the need of having to allocate an intermediate `hstring`. 🙂 ## Validation Steps Performed I followed the reproduction instructions of #3706 and #3745 and ensured the issue doesn't happen anymore. Closes #3645 Closes #3706 Closes #3745

zadjii-msft · 2020-01-08T18:11:36Z

Wait though we're not sure this is fixed, but the others were

ghost · 2020-01-14T17:15:13Z

🎉This issue was addressed in #4140, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links:

spindensity · 2020-01-14T17:22:17Z

The problem is still here.

Windows terminal v0.8.10091.0

zadjii-msft · 2020-01-14T17:29:19Z

Welp the bot got confused here.

lhecker · 2020-01-14T18:05:55Z

Sorry for your troubles @zadjii-msft. And I'm sorry for causing this confusion.
I commited my changes as "Fixes/Closes #3745", as I was unable to reproduce this issue with my changes.
It turned out though that this issue simply doesn't happen anymore in an upcoming Windows version - Windows 20H1 - set to be released in spring this year and a version I'm already using on my PC (through the Windows Insiders Program). Older versions still have this issue, which is why it was reopened.

## Summary of the Pull Request Currently, while in IME mode, selections with the Emoji/Kaomoji/Symbol Picker (which is brought up with <kbd>win+.</kbd>) are not displayed until the user starts a new composition. This is due to the fact that we hide the TextBlock when we receive a CompositionCompleted event, and we only show the TextBlock when we receive a CompositionStarted event. Input from the picker does not count as a composition, so we were never showing the text box, even if the symbols were thrown into the inputBuffer. In addition, we weren't receiving CompositionStarted events when we expected to. We should be showing the TextBlock when we receive _any_ text, so we should make the TextBlock visible inside of `TextUpdatingHandler`. Furthermore, some really helpful discussion in #3745 around wrapping the `NotifyTextChanged` call with a `NotifyFocusLeave` and a `NotifyFocusEnter` allowed the control to much more consistently determine when a CompositionStarted and a CompositionEnded. I've also went around and replaced casts with saturating casts, and have removed the line that sets the `textBlock.Width()` so that it would automatically set its width. This resolves the issue where while composing a sentence, the textBlock would be too small to contain all the text, so it would be cut off, but the composition is still valid and still able to continue. ## PR Checklist * [x] Closes #4148 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed ## Validation Steps Performed Tested picking emojis, kaomojis, and symbols with numerous different languages.

leonMSFT · 2020-03-04T19:36:05Z

I'd be curious to see if this still repros considering #4688 and #4796 should have alleviated this issue (I think). I personally can't seem to repro it anymore, so I'll ask others to try it out and if this doesn't seem to occur anymore, I'll close the issue!

zyy1998 · 2020-03-05T00:29:58Z

I'd be curious to see if this still repros considering #4688 and #4796 should have alleviated this issue (I think). I personally can't seem to repro it anymore, so I'll ask others to try it out and if this doesn't seem to occur anymore, I'll close the issue!

Actually when I upgraded my system to 10.0.19564.0 preview version， this issue disappeared.

leonMSFT · 2020-03-12T15:28:57Z

Thanks for the confirmation! I've also checked on one of my machines running an older version of windows and I can repro, but once I'm on a newer build, it doesn't repro anymore. I've also checked with some other members of the team and they can't repro either, so I'll go ahead and close this one.

Lemmingh · 2020-03-19T10:53:58Z

After upgrading Terminal to version 0.10.761.0, the problem also disappears on Windows Version 1909.

Windows build number: 10.0.18363.720
Windows Terminal version: 0.10.761.0

IME: Microsoft Pinyin

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 27, 2019

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 27, 2019

zadjii-msft added this to the Terminal v1.0 milestone Nov 27, 2019

dotSlashLu mentioned this issue Nov 29, 2019

Stucked if type "\" in Chinese input method #3775

Closed

DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 2, 2019

Lemmingh mentioned this issue Dec 16, 2019

When entering a Chinese punctuation, it acts like keeping hitting the key #3706

Closed

lhecker mentioned this issue Jan 7, 2020

Fix IME/CoreTextEditContext not being reset properly #4140

Merged

ghost added the In-PR This issue has a related PR label Jan 8, 2020

ghost closed this as completed in #4140 Jan 8, 2020

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 8, 2020

zadjii-msft reopened this Jan 8, 2020

zadjii-msft removed the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 14, 2020

DHowett-MSFT mentioned this issue Jan 14, 2020

Input a dot need to press the dot key twice, when Microsoft Pinyin Input Method in half-width punctuation mode. #4208

Closed

cinnamon-msft added the v1-Scrubbed label Jan 23, 2020

DHowett-MSFT mentioned this issue Feb 7, 2020

You have to double hit the key to get the chinese punctuation corretly in vim/neovim in this terminal! #4500

Closed

leonMSFT mentioned this issue Feb 21, 2020

Display Emojis, Kaomojis, and symbols while in IME mode #4688

Merged

3 tasks

leonMSFT self-assigned this Mar 12, 2020

leonMSFT closed this as completed Mar 12, 2020

ghost added the Needs-Tag-Fix Doesn't match tag requirements label Mar 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Needs to input twice to insert a single Chinese symbol #3745

Needs to input twice to insert a single Chinese symbol #3745

hez2010 commented Nov 27, 2019 •

edited

Loading

spindensity commented Nov 28, 2019

mkitzan commented Nov 30, 2019 •

edited

Loading

mkitzan commented Nov 30, 2019 •

edited

Loading

mkitzan commented Dec 1, 2019

mkitzan commented Dec 2, 2019

zadjii-msft commented Dec 2, 2019

lhecker commented Jan 6, 2020

zadjii-msft commented Jan 7, 2020

lhecker commented Jan 7, 2020 •

edited

Loading

zadjii-msft commented Jan 8, 2020

ghost commented Jan 14, 2020

spindensity commented Jan 14, 2020

zadjii-msft commented Jan 14, 2020

lhecker commented Jan 14, 2020

leonMSFT commented Mar 4, 2020

zyy1998 commented Mar 5, 2020

leonMSFT commented Mar 12, 2020

Lemmingh commented Mar 19, 2020

Needs to input twice to insert a single Chinese symbol #3745

Needs to input twice to insert a single Chinese symbol #3745

Comments

hez2010 commented Nov 27, 2019 • edited Loading

Environment

Steps to reproduce

Expected behavior

Actual behavior

spindensity commented Nov 28, 2019

mkitzan commented Nov 30, 2019 • edited Loading

mkitzan commented Nov 30, 2019 • edited Loading

mkitzan commented Dec 1, 2019

mkitzan commented Dec 2, 2019

zadjii-msft commented Dec 2, 2019

lhecker commented Jan 6, 2020

zadjii-msft commented Jan 7, 2020

lhecker commented Jan 7, 2020 • edited Loading

zadjii-msft commented Jan 8, 2020

ghost commented Jan 14, 2020

spindensity commented Jan 14, 2020

zadjii-msft commented Jan 14, 2020

lhecker commented Jan 14, 2020

leonMSFT commented Mar 4, 2020

zyy1998 commented Mar 5, 2020

leonMSFT commented Mar 12, 2020

Lemmingh commented Mar 19, 2020

hez2010 commented Nov 27, 2019 •

edited

Loading

mkitzan commented Nov 30, 2019 •

edited

Loading

mkitzan commented Nov 30, 2019 •

edited

Loading

lhecker commented Jan 7, 2020 •

edited

Loading