Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo can't build in a directory with a space #15370

Closed
zadjii-msft opened this issue May 17, 2023 · 2 comments · Fixed by #15447
Closed

Repo can't build in a directory with a space #15370

zadjii-msft opened this issue May 17, 2023 · 2 comments · Fixed by #15447
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Reverted all changes to OpenConsole.sln by removing and recloning the project.

Picked: image

Restored and updated submodules git submodule update --init --recursive

Ignored warning about incorrect configurations. In the Debug menu, I changed "Application process" and "Background task process" to "Native Only".

Build it, had an issue with nuget packages:

Nuget Package Restore 2023-05-12 114632

Solved that by building with Powershell. This installed the packages, but this time build ended with errors. Afterwards I deleted the Obj and Bin folder of the project and build it with visual studio, getting the same erros as before, but getting similar errors with PowerShell now as well:

Same Errors

image

image

Btw, the software not being able to be build when someone has a username that contains a space. This may be a new issue? If so, I could make a new issue for it.
Can't help but being bugged by not having the project in my preferable location.

Originally posted by @Jaswir in #15127 (comment)
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 17, 2023
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 17, 2023
@zadjii-msft
Copy link
Member Author

Almost certainly the issue is in: https://github.com/microsoft/terminal/blob/main/build/rules/GenerateSxsManifestsFromWinmds.targets

@zadjii-msft zadjii-msft added this to the Backlog milestone May 17, 2023
@zadjii-msft zadjii-msft added the good first issue This is a fix that might be easier for someone to do as a first contribution label May 17, 2023
@nchetan
Copy link

nchetan commented May 18, 2023

Taking a look to see if I can be of help.

@ebarnabas644 ebarnabas644 mentioned this issue May 25, 2023
Merged
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 25, 2023
microsoft-github-policy-service bot pushed a commit that referenced this issue Jun 6, 2023
@ebarnabas644
Project build with space in filepath fix (#15447)
c627991 
## Summary of the Pull Request
Fixing a problem where the repo build failed when the project location
path contained space character.

## References and Relevant Issues
Closes #15370 

## Detailed Description of the Pull Request / Additional comments
Placing missing quote, amp and apos symbols when calling commands with
filepath parameters.

## Validation Steps Performed
Built locally.

## PR Checklist
- [x] Closes #xxx
- [x] Tests added/passed
- [x] Documentation updated
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [x] Schema updated (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Project build with space in filepath fix ebarnabas644/terminal
2 participants
@zadjii-msft @nchetan