Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Window Terimal Preview - Tearout tab] : User is not able to perform the 'Tearout', 'Transfer' tab functionality using keyboard. #15156

Closed
Tracked by #14957
Saiteja341 opened this issue Apr 11, 2023 · 5 comments · Fixed by #15258
Labels
A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32

Comments

@Saiteja341
Copy link

Saiteja341 commented Apr 11, 2023

Windows Terminal version

1.18.902.0

Windows build number

25324.1011

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 25324.1011)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:

1.Open Windows Terminal.
2.Open multiple 'Command prompt' using 'Ctrl + Shift + 1' keys.
3.Now try to perform 'Tearout' and 'Transfer' tab functionality using keyboard.
4.Observe the issue.

Users Experience:
Users who rely on keyboard will get impacted here & fail to use the functionality effectively.

Guideline link:
https://www.w3.org/TR/WCAG21/#keyboard

Attachments:
User is not able to perform the 'Tearout', 'Transfer' tab functionality using keyboard..zip

Expected Behavior

User should be able to perform the 'Tearout', 'Transfer' tab functionality using keyboard.

Even shortcut should be defined to perform 'Tearout', 'Transfer' tab- functionality.

Actual Behavior

User is not able to perform the 'Tearout', 'Transfer' tab functionality using keyboard.

Even no shortcut is defined for 'Tearout', 'Transfer' tab- functionality

@Saiteja341 Saiteja341 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 11, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev1 Accessibility tracking labels Apr 11, 2023
@zadjii-msft
Copy link
Member

zadjii-msft commented Apr 11, 2023

@Saiteja341 The user is free to define actions like:

        { "keys": "f1", "command": { "action": "moveTab", "window": "1" }, },
        { "keys": "f2", "command": { "action": "moveTab", "window": "2" }, },
        { "keys": "f3", "command": { "action": "movePane", "window": "1" }, },
        { "keys": "f4", "command": { "action": "movePane", "window": "2" }, },

in their settings, which would allow them to move tabs / panes to other windows using just the keyboard. Is that sufficient?

@Saiteja341
Copy link
Author

Hi @zadjii-msft ,

Thanks for providing these command but what if a user doesn't know about these commands, they will not able to perform this functionality.

It should be either pre-define in the terminal's action, So that user might we able to use this functionality with keyboard shortcuts.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 12, 2023
@zadjii-msft
Copy link
Member

@Saiteja341 Would a default action for "move this tab/pane to a new window" be sufficient here? It should be fairly trivial for us to add a pair of

        { "command": { "action": "moveTab", "window": "new" }, },
        { "command": { "action": "movePane", "window": "new" }, },

default actions, and have them just work out of the box.

@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone Apr 13, 2023
@zadjii-msft
Copy link
Member

@Saiteja341 gentle ping ☺️ Would a default action for "move this tab/pane to a new window" be sufficient here?

zadjii-msft added a commit that referenced this issue Apr 28, 2023
This was in pursuit of #15156. I need an ack from OP to make sure this is good enough.

Related to #14957
microsoft-github-policy-service bot pushed a commit that referenced this issue May 1, 2023
This was in pursuit of #15156. I need an ack from OP to make sure this
is good enough.

Related to #14957
@zadjii-msft
Copy link
Member

We added the above actions in #15258. If those are insufficient, OP can feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev1 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants