Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer exports only contain spaces #14378

Closed
ianjoneill opened this issue Nov 12, 2022 · 2 comments · Fixed by #14379
Closed

Buffer exports only contain spaces #14378

ianjoneill opened this issue Nov 12, 2022 · 2 comments · Fixed by #14379
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@ianjoneill
Copy link
Contributor

Windows Terminal version

main - a01500f

Windows build number

10.0.22621.819

Other Software

No response

Steps to reproduce

Open a PowerShell tab, right click on the tab and select Export Text.

Expected Behavior

The tab content to be exported to a file.

Actual Behavior

Lots of spaces are exported instead.

@ianjoneill ianjoneill added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 12, 2022
@ghost ghost added the In-PR This issue has a related PR label Nov 12, 2022
@237dmitry
Copy link

237dmitry commented Nov 12, 2022

The only problem I have when exporting text that is its incorrect formatting, shifting each next line to the right of the previous one if in the tab is running an application with pseudographic interface. Command shells, push, cmd, are exported without errors.

@ghost ghost closed this as completed in #14379 Nov 12, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 12, 2022
ghost pushed a commit that referenced this issue Nov 12, 2022
## Summary of the Pull Request
Ensures that reading the buffer content actually returns the content.

## References
Regressed in #13626.

## PR Checklist
* [x] Closes #14378
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Tests added/passed

## Validation Steps Performed
Added a test.
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14379, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants