[1.14] Opening a tab makes the Terminal window resize #13158
Labels
Area-Windowing
Window frame, quake mode, tearout
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Priority-0
Bugs that we consider release-blocking/recall-class (P0)
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Severity-Blocking
We won't ship a release like this! No-siree.
Milestone
Comments
|
This can also be reproduced from a maximized Terminal window. Specifically:
|
4 tasks
DHowett
pushed a commit
that referenced
this issue
May 25, 2022
This is a big hammer to put out this fire. We're keeping the hiding around for now, cause we think that's likely the one that the internal tests use that we really care about here. If we need to bring this back, we can. * [x] Closes #13158 * [x] Closes #13162 * [x] Validated these both manually * [x] `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works
DHowett
pushed a commit
that referenced
this issue
May 25, 2022
This is a big hammer to put out this fire. We're keeping the hiding around for now, cause we think that's likely the one that the internal tests use that we really care about here. If we need to bring this back, we can. * [x] Closes #13158 * [x] Closes #13162 * [x] Validated these both manually * [x] `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works (cherry picked from commit 11b810e) Service-Card-Id: 82371517 Service-Version: 1.14
|
🎉This issue was addressed in #13164, which has now been successfully released as Handy links: |
zadjii-msft
added a commit
that referenced
this issue
Jul 28, 2022
…ing with taskbar Curiously, at least on Windows 10 (and rarely on Windows 11), if you minimize the Terminal by clicking on the taskbar, then alt-tab to try and restore the window, the Taskbar will decide to call `SwitchToWindow` on the invisible, owned ConPTY window instead of the main window. When that happens, ConPTY'll get a `WM_SIZE(SIZE_RESTORED, lParam=0)`. The main window will NOT get a `SwitchToWindow` called. If ConPTY doesn't actually inform the hosting process about this, then the main HWND might stay hidden. * Refer to #13158 where we disabled this. * Closes #13589 * **TODO** Does this also address #13248 * Tested manually on a Windows 10 VM. * Confirmed that opening tabs while maximized/snapped doesn't restore down. * `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works
ghost
pushed a commit
that referenced
this issue
Aug 1, 2022
…ing with taskbar (#13624) Curiously, at least on Windows 10 (and rarely on Windows 11), if you minimize the Terminal by clicking on the taskbar, then alt-tab to try and restore the window, the Taskbar will decide to call `SwitchToWindow` on the invisible, owned ConPTY window instead of the main window. When that happens, ConPTY'll get a `WM_SIZE(SIZE_RESTORED, lParam=0)`. The main window will NOT get a `SwitchToWindow` called. If ConPTY doesn't actually inform the hosting process about this, then the main HWND might stay hidden. * Refer to #13158 where we disabled this. * Closes #13589 * Closes #13248 * Tested manually on a Windows 10 VM. * Confirmed that opening tabs while maximized/snapped doesn't restore down. * `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works
DHowett
pushed a commit
that referenced
this issue
Aug 8, 2022
…ing with taskbar (#13624) Curiously, at least on Windows 10 (and rarely on Windows 11), if you minimize the Terminal by clicking on the taskbar, then alt-tab to try and restore the window, the Taskbar will decide to call `SwitchToWindow` on the invisible, owned ConPTY window instead of the main window. When that happens, ConPTY'll get a `WM_SIZE(SIZE_RESTORED, lParam=0)`. The main window will NOT get a `SwitchToWindow` called. If ConPTY doesn't actually inform the hosting process about this, then the main HWND might stay hidden. * Refer to #13158 where we disabled this. * Closes #13589 * Closes #13248 * Tested manually on a Windows 10 VM. * Confirmed that opening tabs while maximized/snapped doesn't restore down. * `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works (cherry picked from commit d1fc112) Service-Card-Id: 84673887 Service-Version: 1.15
PKRoma
pushed a commit
to PKRoma/Terminal
that referenced
this issue
Oct 15, 2022
…ing with taskbar (microsoft#13624) Curiously, at least on Windows 10 (and rarely on Windows 11), if you minimize the Terminal by clicking on the taskbar, then alt-tab to try and restore the window, the Taskbar will decide to call `SwitchToWindow` on the invisible, owned ConPTY window instead of the main window. When that happens, ConPTY'll get a `WM_SIZE(SIZE_RESTORED, lParam=0)`. The main window will NOT get a `SwitchToWindow` called. If ConPTY doesn't actually inform the hosting process about this, then the main HWND might stay hidden. * Refer to microsoft#13158 where we disabled this. * Closes microsoft#13589 * Closes microsoft#13248 * Tested manually on a Windows 10 VM. * Confirmed that opening tabs while maximized/snapped doesn't restore down. * `[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)` still works (cherry picked from commit d1fc112) Service-Card-Id: 84673887 Service-Version: 1.15 (cherry picked from commit b670800) Service-Card-Id: 84673886 Service-Version: 1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version
1.14.1433.0
Windows build number
10.0.22000.0
Other Software
No response
Steps to reproduce
Open Terminal and snap the window to your choice of left, right, or top. One may also snap another app to the right or left (opposite the terminal). Then open a new tab.
Uploading ellgramar-WinTermPrev-SnapBehaviour.mp4…
Expected Behavior
When opening a new tab, The window was expected to stay snapped to where it was placed.
ellgramar-WinTerm-ExpectedSnapBehaviour.mp4
Actual Behavior
When a new tab was opened, the window de-snapped, resized to the default launch dimensions and returned to the last free floating location it had been.
The text was updated successfully, but these errors were encountered: