Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should also restore runtime tab titles #11878

Closed
Tracked by #9800
jzymx50 opened this issue Dec 4, 2021 · 2 comments · Fixed by #12073
Closed
Tracked by #9800

Terminal should also restore runtime tab titles #11878

jzymx50 opened this issue Dec 4, 2021 · 2 comments · Fixed by #12073
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
22H2

Comments

@jzymx50
Copy link

jzymx50 commented Dec 4, 2021

Description of the new feature/enhancement

I am using version 1.12 and the window restoration feature is great. But I find it only memorizes the number of panes or tabs you opened last time. It would be better if it can also restore:

  • The name of the tabs. (I often open a tab for the server running and another for git commands. So I rename the tab to make it clear.)
  • The working directory of each tab or pane.

Thanks! 😸

Proposed technical implementation details (optional)
@jzymx50 jzymx50 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 4, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 4, 2021
@Rosefield
Copy link
Contributor

Rosefield commented Dec 6, 2021 •
edited
Loading

For the name of tabs, that can be added to the list in #9800. Right now the terminal saves the tab title attached to a pane (from using the tabTitle argument on creation), but I missed the one that can be set otherwise at runtime.

For the working directory, if you have configured your shell to use the OSC 9;9 code to tell the terminal what your directory is, it will save that currently. MicrosoftDocs/terminal#449 has documentation for how to add that.

@zadjii-msft zadjii-msft changed the title Make window restoration more powerful Terminal should also restore runtime tab titles Dec 6, 2021
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Dec 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Dec 6, 2021
@zadjii-msft zadjii-msft mentioned this issue Dec 6, 2021
Open
16 tasks
@zadjii-msft zadjii-msft mentioned this issue Dec 15, 2021
Closed
@Rosefield Rosefield mentioned this issue Dec 31, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Dec 31, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@ghost ghost closed this as completed in #12073 Jan 10, 2022
@ghost ghost removed the In-PR This issue has a related PR label Jan 10, 2022
ghost pushed a commit that referenced this issue Jan 10, 2022
@Rosefield
Persist Runtime TabTitle and Maximize/Focus/Fullscreen states (#12073)
acbfb30 
This commit adds additional information to the persisted window layouts.
- Runtime tab titles
- Focus, Maximized, and Fullscreen modes.

Also,
- Adds actions for Set{Focus,FullScreen} that take a boolean
  to work in addition to the current Toggle{Focus, Fullscreen} actions.
- Adds SetMaximized that takes a boolean.
  This adds the capability to maximize (resp restore) a window using
  standard terminal actions.
  This also involves hooking up a good amount of state tracking between
  the terminal page and the window to see when maximize state has changed
  so that it can be persisted.
- These actions are not added to the default settings, but they could be.
  The intention is that they could assist with automation (and was originally)
  how I planned on persisting the state instead of augmenting the LaunchMode.
- The fullscreen/maximized saving isn't perfect because we don't have a
  way to save the non-maximized/fullscreen size, so exiting the modes
  won't restore whatever the previous size was.

References #9800 
Closes #11878 
Closes #11426
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 10, 2022
@ghost
Copy link

ghost commented Feb 3, 2022

🎉This issue was addressed in #12073, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
22H2
Development

Successfully merging a pull request may close this issue.

Persist Runtime TabTitle and Maximize/Focus/Fullscreen states Rosefield/terminal
3 participants
@Rosefield @zadjii-msft @jzymx50