Switch from ConhostConnection to the official ConPTY API #1131
Labels
Area-TerminalConnection
Issues pertaining to the terminal<->backend connection interface
Issue-Task
It's a feature request, but it doesn't really need a major design.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Comments
DHowett-MSFT
pushed a commit
that referenced
this issue
Nov 6, 2019
DHowett-MSFT
pushed a commit
that referenced
this issue
Nov 6, 2019
This commit deletes ConhostConnection and replaces it with ConptyConnection. The ConptyConnection uses CreatePseudoConsole and depends on winconpty to override the one from kernel32. * winconpty must be packagebale, so I've added GetPackagingOutputs. * To validate this, I added conpty.dll to the MSIX regression script. * I moved the code from conpty-universal that deals with environment strings into the types library. This puts us in a way better place to implement #2563, as we can now separately detect a failure to launch a pseudoconsole, a failure to CreateProcess, and a failure of the launched process. Fixes #1131.
5 tasks
DHowett-MSFT
pushed a commit
that referenced
this issue
Nov 6, 2019
This commit deletes ConhostConnection and replaces it with ConptyConnection. The ConptyConnection uses CreatePseudoConsole and depends on winconpty to override the one from kernel32. * winconpty must be packagebale, so I've added GetPackagingOutputs. * To validate this, I added conpty.dll to the MSIX regression script. * I moved the code from conpty-universal that deals with environment strings into the types library. This puts us in a way better place to implement #2563, as we can now separately detect a failure to launch a pseudoconsole, a failure to CreateProcess, and a failure of the launched process. Fixes #1131.
DHowett-MSFT
pushed a commit
that referenced
this issue
Nov 6, 2019
This commit deletes ConhostConnection and replaces it with ConptyConnection. The ConptyConnection uses CreatePseudoConsole and depends on winconpty to override the one from kernel32. * winconpty must be packagebale, so I've added GetPackagingOutputs. * To validate this, I added conpty.dll to the MSIX regression script. * I moved the code from conpty-universal that deals with environment strings into the types library. This puts us in a way better place to implement #2563, as we can now separately detect a failure to launch a pseudoconsole, a failure to CreateProcess, and a failure of the launched process. Fixes #1131.
DHowett-MSFT
pushed a commit
that referenced
this issue
Nov 6, 2019
This commit deletes ConhostConnection and replaces it with ConptyConnection. The ConptyConnection uses CreatePseudoConsole and depends on winconpty to override the one from kernel32. * winconpty must be packageable, so I've added GetPackagingOutputs. * To validate this, I added conpty.dll to the MSIX regression script. * I moved the code from conpty-universal that deals with environment strings into the types library. This puts us in a way better place to implement #2563, as we can now separately detect a failure to launch a pseudoconsole, a failure to CreateProcess, and an unexpected termination of the launched process. Fixes #1131.
|
🎉This issue was addressed in #3461, which has now been successfully released as Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Making the switch from spawning conhost directly to using
CreatePseudoConsoleand otherwise hosting a pseudoconsole session affords us a number of benefits.CreateProcessthe shell directly and track its exit independent from that of the pseudoconsole hostThe text was updated successfully, but these errors were encountered: