-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
dca7df5
commit dd25ed7
Showing
1 changed file
with
8 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -960,21 +960,23 @@ namespace SettingsModelUnitTests | |
"actions": [ | ||
{ | ||
"name": "foo", | ||
"command": "closePane", | ||
"command": { "action": "sendInput", "input": "just some input" }, | ||
"keys": "ctrl+shift+w" | ||
} | ||
] | ||
})" }; | ||
|
||
// Key difference: the close pane action now has a generated ID | ||
// Key differences: - the sendInput action now has a generated ID | ||
// - this generated ID was created at the time of writing this test, | ||
// and should remain robust (i.e. everytime we hash the args we should get the same result) | ||
Check failure Code scanning / check-spelling Unrecognized Spelling Error
everytime is not a recognized word. (unrecognized-spelling)
|
||
static constexpr std::string_view newSettingsJson{ R"( | ||
{ | ||
"actions": [ | ||
{ | ||
"name": "foo", | ||
"command": "closePane", | ||
"command": { "action": "sendInput", "input": "just some input" }, | ||
"keys": "ctrl+shift+w", | ||
"id" : "User.closePane" | ||
"id" : "User.sendInput.3448838294654165202" | ||
} | ||
] | ||
})" }; | ||
|
@@ -1039,7 +1041,7 @@ namespace SettingsModelUnitTests | |
"actions": [ | ||
{ | ||
"name": "foo", | ||
"command": { "action": "sendInput", "input": "VT Griese Mode" }, | ||
"command": { "action": "sendInput", "input": "this is some other input string" }, | ||
"keys": "ctrl+shift+w" | ||
} | ||
] | ||
|
@@ -1051,7 +1053,7 @@ namespace SettingsModelUnitTests | |
"actions": [ | ||
{ | ||
"name": "foo", | ||
"command": { "action": "sendInput", "input": "VT Griese Mode" }, | ||
"command": { "action": "sendInput", "input": "this is some other input string" }, | ||
"keys": "ctrl+shift+w" | ||
} | ||
] | ||
|