Skip to content

Commit

Permalink
change tests
Browse files Browse the repository at this point in the history
  • Loading branch information
PankajBhojwani committed Apr 1, 2024
1 parent dca7df5 commit dd25ed7
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/cascadia/UnitTests_SettingsModel/SerializationTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -960,21 +960,23 @@ namespace SettingsModelUnitTests
"actions": [
{
"name": "foo",
"command": "closePane",
"command": { "action": "sendInput", "input": "just some input" },
"keys": "ctrl+shift+w"
}
]
})" };

// Key difference: the close pane action now has a generated ID
// Key differences: - the sendInput action now has a generated ID
// - this generated ID was created at the time of writing this test,
// and should remain robust (i.e. everytime we hash the args we should get the same result)

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

everytime is not a recognized word. (unrecognized-spelling)
static constexpr std::string_view newSettingsJson{ R"(
{
"actions": [
{
"name": "foo",
"command": "closePane",
"command": { "action": "sendInput", "input": "just some input" },
"keys": "ctrl+shift+w",
"id" : "User.closePane"
"id" : "User.sendInput.3448838294654165202"
}
]
})" };
Expand Down Expand Up @@ -1039,7 +1041,7 @@ namespace SettingsModelUnitTests
"actions": [
{
"name": "foo",
"command": { "action": "sendInput", "input": "VT Griese Mode" },
"command": { "action": "sendInput", "input": "this is some other input string" },
"keys": "ctrl+shift+w"
}
]
Expand All @@ -1051,7 +1053,7 @@ namespace SettingsModelUnitTests
"actions": [
{
"name": "foo",
"command": { "action": "sendInput", "input": "VT Griese Mode" },
"command": { "action": "sendInput", "input": "this is some other input string" },
"keys": "ctrl+shift+w"
}
]
Expand Down

0 comments on commit dd25ed7

Please sign in to comment.