Fix Header Alignment on Mobile and Dark Mode Visibility #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
reviewed
Oct 10, 2023
| @@ -27,16 +27,15 @@ const advocates: IAdvocate[] = [ | |||
|
|
|||
| function AdvocateCard(props: { advocate: IAdvocate }): JSX.Element { | |||
| const advocate: IAdvocate = props.advocate; | |||
|
|
|||
| console.log(advocate); | |||
There was a problem hiding this comment.
Please remove this debugging statement.
There was a problem hiding this comment.
Ok @octogonz remove the debugging statement.
|
🏆 Thanks for making these improvements! |
octogonz
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This PR addresses two issues:
Header Alignment on Mobile View: The header elements were misaligned on mobile devices, with one button on the left and another on the right. This PR fixes the alignment issue by centering the header elements horizontally on mobile devices.
Dark Mode Visibility: In dark mode, the company names listed in the "Who's using Rush?" section were displayed in black, making them nearly impossible to read against the dark background. This PR ensures that company names are displayed with a legible and contrasting color in both light and dark modes to improve accessibility and readability.
Related Issues
Screenshots (if applicable)
Before Fix:
After Fix:
Before Fix:
After Fix:
Testing Done
This PR resolves the reported issues and enhances the user experience by improving the header alignment on mobile devices and ensuring better visibility in dark mode.